Page MenuHomePhabricator
Differential D8761

[identity] db method to get inbound keys for user
ClosedPublic
Actions

Authored by varun on Aug 8 2023, 7:40 AM.
Tags
None
Referenced Files
F3364009: D8761.id29618.diff
Mon, Nov 25, 3:39 AM
Unknown Object (File)
Sat, Nov 23, 11:45 PM
Unknown Object (File)
Sat, Nov 23, 12:58 PM
Unknown Object (File)
Sat, Nov 23, 12:58 PM
Unknown Object (File)
Fri, Nov 22, 5:35 AM
Unknown Object (File)
Fri, Nov 22, 12:00 AM
Unknown Object (File)
Mon, Nov 18, 7:09 AM
Unknown Object (File)
Fri, Nov 8, 9:13 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
• jon
bartek
Commits
rCOMMa91792c497ce: [identity] db method to get inbound keys for user
Summary

Use username/wallet address to get the inbound keys for a user

Test Plan

tested in next diff

Diff Detail

Repository
rCOMM Comm
Branch
getInboundKeysForUser (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Aug 8 2023, 7:40 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 8 2023, 7:40 AM
Harbormaster completed remote builds in B21589: Diff 29618.Aug 8 2023, 7:58 AM
varun requested review of this revision.Aug 8 2023, 7:58 AM
bartek accepted this revision.Aug 8 2023, 8:29 AM

Just minor nits ;)

services/identity/src/database.rs
581–585

My preference, but up to you.

Note that to format let-else you need to use cargo +nightly fmt - it is available in rustfmt v 1.6+

592

Minor optimization

This revision is now accepted and ready to land.Aug 8 2023, 8:29 AM
bartek added inline comments.Aug 8 2023, 8:33 AM
services/identity/src/database.rs
580

Maybe introduce some type aliases for these maps? It becomes difficult to keep up with what they represent.

• jon requested changes to this revision.Aug 8 2023, 9:02 AM

I landed D8627, please rebase

This revision now requires changes to proceed.Aug 8 2023, 9:02 AM
varun added a child revision: D8765: [identity] more helpers for identity service.Aug 8 2023, 12:12 PM
varun updated this revision to Diff 30058.Aug 17 2023, 9:02 PM
varun marked 2 inline comments as done.

rebase and address feedback

varun marked an inline comment as done.Aug 17 2023, 9:02 PM
Harbormaster completed remote builds in B21880: Diff 30058.Aug 17 2023, 9:20 PM
• jon accepted this revision.Aug 18 2023, 1:31 PM
• jon added inline comments.
services/identity/src/database.rs
737–739 ↗(On Diff #30058)

After D8721, this could be just be

This revision is now accepted and ready to land.Aug 18 2023, 1:31 PM
varun added inline comments.Aug 30 2023, 11:05 AM
services/identity/src/database.rs
737–739 ↗(On Diff #30058)

will address this in a new diff. i'd like to make the to_string method return a String instead of &String first

Closed by commit rCOMMa91792c497ce: [identity] db method to get inbound keys for user (authored by varun). · Explain WhyAug 30 2023, 11:38 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMa91792c497ce: [identity] db method to get inbound keys for user.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
74 lines

Diff 29618

View Options

services/identity/src/database.rs

Loading...