Page MenuHomePhabricator
Differential D8855

[web] Introduce `UserEmojiAvatarSelectionModal` component
ClosedPublic
Actions

Authored by atul on Aug 17 2023, 1:00 PM.
Tags
None
Referenced Files
F3297552: D8855.id30168.diff
Sun, Nov 17, 2:49 AM
F3295998: D8855.diff
Sun, Nov 17, 12:22 AM
Unknown Object (File)
Sun, Nov 10, 3:59 PM
Unknown Object (File)
Sun, Nov 10, 3:59 PM
Unknown Object (File)
Sun, Nov 10, 3:59 PM
Unknown Object (File)
Sun, Nov 10, 3:59 PM
Unknown Object (File)
Sun, Nov 10, 3:58 PM
Unknown Object (File)
Tue, Nov 5, 2:12 AM
View All 86 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMMf71b8c481d2b: [web] Introduce `UserEmojiAvatarSelectionModal` component
Summary

The EmojiAvatarSelectionModal component was user avatar specific. In this diff we "lift" user avatar-specific logic to UserEmojiAvatarSelectionModal and make EmojiAvatarSelectionModal user/thread-avatar agnostic.

The "API" for EmojiAvatarSelectionModal will be the currentAvatar, defaultAvatar, setEmojiAvatar, and avatarSaveInProgress props. This should allow maximal reuse of EmojiAvatarSelectionModal component.

Depends on D8854

Test Plan

Setting user emoji avatar continues working as expected/before.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Aug 17 2023, 1:00 PM
Herald added a subscriber: tomek. · View Herald TranscriptAug 17 2023, 1:00 PM
atul published this revision for review.Aug 17 2023, 1:04 PM
atul edited the test plan for this revision. (Show Details)
atul updated this revision to Diff 30045.Aug 17 2023, 1:12 PM

newline after // @flow

Harbormaster completed remote builds in B21866: Diff 30044.Aug 17 2023, 1:21 PM
atul added a child revision: D8856: [web] Introduce `ThreadEmojiAvatarSelectionModal`.Aug 17 2023, 1:31 PM
Harbormaster completed remote builds in B21867: Diff 30045.Aug 17 2023, 1:33 PM
ashoat accepted this revision.Aug 18 2023, 3:46 PM

Not looking too closely, but it seems okay

This revision is now accepted and ready to land.Aug 18 2023, 3:46 PM
atul updated this revision to Diff 30167.Aug 21 2023, 4:01 PM

rebase and alnd

This revision was landed with ongoing or failed builds.Aug 21 2023, 4:17 PM
Closed by commit rCOMMf71b8c481d2b: [web] Introduce `UserEmojiAvatarSelectionModal` component (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMf71b8c481d2b: [web] Introduce `UserEmojiAvatarSelectionModal` component.
Harbormaster completed remote builds in B21967: Diff 30167.Aug 21 2023, 4:20 PM

Revision Contents
Changeset List

Diff 30044

View Options

web/avatars/edit-user-avatar-menu.react.js

Loading...
View Options

web/avatars/emoji-avatar-selection-modal.react.js

Loading...
View Options

web/avatars/user-emoji-avatar-selection-modal.react.js

Loading...