Page MenuHomePhabricator
Differential D8765

[identity] more helpers for identity service
ClosedPublic
Actions

Authored by varun on Aug 8 2023, 12:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 24, 4:45 PM
Unknown Object (File)
Thu, Apr 17, 10:38 AM
Unknown Object (File)
Thu, Apr 17, 8:22 AM
Unknown Object (File)
Thu, Apr 17, 2:55 AM
Unknown Object (File)
Wed, Apr 16, 10:12 PM
Unknown Object (File)
Wed, Apr 16, 6:52 AM
Unknown Object (File)
Mar 23 2025, 9:59 AM
Unknown Object (File)
Mar 12 2025, 7:20 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
• jon
bartek
Commits
rCOMMe1591be9eb39: [identity] more helpers for identity service
Summary

From the device_info HashMap, we need to construct an InboundKeyInfo struct. These are some helper functions to do that.

Depends on D8761

Test Plan

Tested in subsequent diff when we actually call the helpers

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Aug 8 2023, 12:12 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 8 2023, 12:12 PM
Harbormaster completed remote builds in B21612: Diff 29652.Aug 8 2023, 12:47 PM
varun requested review of this revision.Aug 8 2023, 12:47 PM
• jon requested changes to this revision.Aug 9 2023, 5:36 PM
• jon added inline comments.
services/identity/src/client_service.rs
897–901 ↗(On Diff #29652)

This file is already ~1000 lines long. Do you mind if we have a grpc_utils.rs, which contains all these "marshaling to types" helpers?

Also, we might be able to do impl TryFrom<HashMap<String, String>> for InboundKeyInfo, which would just make the call into:

let inbound_key_info = InboundKeyInfo::try_from(query)?;
931–934 ↗(On Diff #29652)

In D8607 I added something similar

This revision now requires changes to proceed.Aug 9 2023, 5:36 PM
varun marked an inline comment as done.Aug 17 2023, 9:38 PM
varun added inline comments.
services/identity/src/client_service.rs
931–934 ↗(On Diff #29652)

I couldn't find the method you added...

varun updated this revision to Diff 30059.Aug 17 2023, 9:39 PM

address feedback

varun added a child revision: D8863: [identity] getInboundKeysForUser RPC implementation.Aug 17 2023, 9:48 PM
Harbormaster completed remote builds in B21881: Diff 30059.Aug 17 2023, 9:57 PM
varun added inline comments.Aug 18 2023, 7:26 AM
services/identity/src/grpc_utils.rs
26

this should just be impl actually, not impl<'a>. I have fixed it in the subsequent diff

• jon accepted this revision.Aug 18 2023, 1:32 PM
• jon added inline comments.
services/identity/src/client_service.rs
931–934 ↗(On Diff #29652)

It was implemented in D8721

This revision is now accepted and ready to land.Aug 18 2023, 1:32 PM
varun added inline comments.Aug 30 2023, 11:15 AM
services/identity/src/client_service.rs
931–934 ↗(On Diff #29652)

the trait implementation is HashMap<String, AttributeValue> but the type I'm dealing with here is HashMap<String, String>

Closed by commit rCOMMe1591be9eb39: [identity] more helpers for identity service (authored by varun). · Explain WhyAug 30 2023, 11:38 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMe1591be9eb39: [identity] more helpers for identity service.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
78 lines
2 lines
86 lines
1 line
2 lines

Diff 30059

View Options

services/identity/src/client_service.rs

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Lines
class ChatThreadList extends React.PureComponent<Props> { class ChatThreadList extends React.PureComponent<Props> {
flatList: ?FlatList<Item>; flatList: ?FlatList<Item>;
constructor(props: Props) { constructor(props: Props) {
super(props); super(props);
} }
componentDidUpdate(prevProps: Props) {
const { searchStatus } = this.props;
const prevSearchStatus = prevProps.searchStatus;
const isActiveOrActivating =
searchStatus === 'active' || searchStatus === 'activating';
const wasActiveOrActivating =
prevSearchStatus === 'active' || prevSearchStatus === 'activating';
if (isActiveOrActivating && !wasActiveOrActivating) {
this.props.searchCancelButtonOpen.setValue(1);
} else if (!isActiveOrActivating && wasActiveOrActivating) {
this.props.searchCancelButtonOpen.setValue(0);
}
const { flatList } = this;
if (!flatList) {
return;
}
if (this.props.searchText !== prevProps.searchText) {
flatList.scrollToOffset({ offset: 0, animated: false });
return;
}
if (searchStatus === 'activating' && prevSearchStatus === 'inactive') {
flatList.scrollToOffset({ offset: 0, animated: true });
}
}
render() { render() {
return this.props.chatThreadList; return this.props.chatThreadList;
} }
flatListRef = (flatList: ?FlatList<Item>) => { flatListRef = (flatList: ?FlatList<Item>) => {
this.flatList = flatList; this.flatList = flatList;
}; };
} }
▲ Show 20 Lines • Show All 412 Lines • ▼ Show 20 Linesfunction ConnectedChatThreadList(props: BaseProps): React.Node {
React.useEffect(() => { React.useEffect(() => {
BackHandler.addEventListener('hardwareBackPress', hardwareBack); BackHandler.addEventListener('hardwareBackPress', hardwareBack);
return () => { return () => {
BackHandler.removeEventListener('hardwareBackPress', hardwareBack); BackHandler.removeEventListener('hardwareBackPress', hardwareBack);
}; };
}, [hardwareBack]); }, [hardwareBack]);
const isActiveOrActivating =
searchStatus === 'active' || searchStatus === 'activating';
React.useEffect(() => {
if (isActiveOrActivating) {
searchCancelButtonOpen.setValue(1);
} else {
searchCancelButtonOpen.setValue(0);
}
}, [isActiveOrActivating, searchCancelButtonOpen]);
React.useEffect(() => {
if (scrollPos.current > 0 && flatListRef.current) {
flatListRef.current.scrollToOffset({ offset: 0, animated: false });
}
}, [searchText]);
const isSearchActivating = searchStatus === 'activating';
React.useEffect(() => {
if (isSearchActivating && scrollPos.current > 0 && flatListRef.current) {
flatListRef.current.scrollToOffset({ offset: 0, animated: true });
}
}, [isSearchActivating]);
return ( return (
<ChatThreadList <ChatThreadList
navigation={navigation} navigation={navigation}
route={route} route={route}
filterThreads={filterThreads} filterThreads={filterThreads}
emptyItem={emptyItem} emptyItem={emptyItem}
searchText={searchText} searchText={searchText}
searchStatus={searchStatus} searchStatus={searchStatus}
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines
View Options

services/identity/src/database.rs

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Lines
class ChatThreadList extends React.PureComponent<Props> { class ChatThreadList extends React.PureComponent<Props> {
flatList: ?FlatList<Item>; flatList: ?FlatList<Item>;
constructor(props: Props) { constructor(props: Props) {
super(props); super(props);
} }
componentDidUpdate(prevProps: Props) {
const { searchStatus } = this.props;
const prevSearchStatus = prevProps.searchStatus;
const isActiveOrActivating =
searchStatus === 'active' || searchStatus === 'activating';
const wasActiveOrActivating =
prevSearchStatus === 'active' || prevSearchStatus === 'activating';
if (isActiveOrActivating && !wasActiveOrActivating) {
this.props.searchCancelButtonOpen.setValue(1);
} else if (!isActiveOrActivating && wasActiveOrActivating) {
this.props.searchCancelButtonOpen.setValue(0);
}
const { flatList } = this;
if (!flatList) {
return;
}
if (this.props.searchText !== prevProps.searchText) {
flatList.scrollToOffset({ offset: 0, animated: false });
return;
}
if (searchStatus === 'activating' && prevSearchStatus === 'inactive') {
flatList.scrollToOffset({ offset: 0, animated: true });
}
}
render() { render() {
return this.props.chatThreadList; return this.props.chatThreadList;
} }
flatListRef = (flatList: ?FlatList<Item>) => { flatListRef = (flatList: ?FlatList<Item>) => {
this.flatList = flatList; this.flatList = flatList;
}; };
} }
▲ Show 20 Lines • Show All 412 Lines • ▼ Show 20 Linesfunction ConnectedChatThreadList(props: BaseProps): React.Node {
React.useEffect(() => { React.useEffect(() => {
BackHandler.addEventListener('hardwareBackPress', hardwareBack); BackHandler.addEventListener('hardwareBackPress', hardwareBack);
return () => { return () => {
BackHandler.removeEventListener('hardwareBackPress', hardwareBack); BackHandler.removeEventListener('hardwareBackPress', hardwareBack);
}; };
}, [hardwareBack]); }, [hardwareBack]);
const isActiveOrActivating =
searchStatus === 'active' || searchStatus === 'activating';
React.useEffect(() => {
if (isActiveOrActivating) {
searchCancelButtonOpen.setValue(1);
} else {
searchCancelButtonOpen.setValue(0);
}
}, [isActiveOrActivating, searchCancelButtonOpen]);
React.useEffect(() => {
if (scrollPos.current > 0 && flatListRef.current) {
flatListRef.current.scrollToOffset({ offset: 0, animated: false });
}
}, [searchText]);
const isSearchActivating = searchStatus === 'activating';
React.useEffect(() => {
if (isSearchActivating && scrollPos.current > 0 && flatListRef.current) {
flatListRef.current.scrollToOffset({ offset: 0, animated: true });
}
}, [isSearchActivating]);
return ( return (
<ChatThreadList <ChatThreadList
navigation={navigation} navigation={navigation}
route={route} route={route}
filterThreads={filterThreads} filterThreads={filterThreads}
emptyItem={emptyItem} emptyItem={emptyItem}
searchText={searchText} searchText={searchText}
searchStatus={searchStatus} searchStatus={searchStatus}
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines
View Options

services/identity/src/grpc_utils.rs

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Lines
class ChatThreadList extends React.PureComponent<Props> { class ChatThreadList extends React.PureComponent<Props> {
flatList: ?FlatList<Item>; flatList: ?FlatList<Item>;
constructor(props: Props) { constructor(props: Props) {
super(props); super(props);
} }
componentDidUpdate(prevProps: Props) {
const { searchStatus } = this.props;
const prevSearchStatus = prevProps.searchStatus;
const isActiveOrActivating =
searchStatus === 'active' || searchStatus === 'activating';
const wasActiveOrActivating =
prevSearchStatus === 'active' || prevSearchStatus === 'activating';
if (isActiveOrActivating && !wasActiveOrActivating) {
this.props.searchCancelButtonOpen.setValue(1);
} else if (!isActiveOrActivating && wasActiveOrActivating) {
this.props.searchCancelButtonOpen.setValue(0);
}
const { flatList } = this;
if (!flatList) {
return;
}
if (this.props.searchText !== prevProps.searchText) {
flatList.scrollToOffset({ offset: 0, animated: false });
return;
}
if (searchStatus === 'activating' && prevSearchStatus === 'inactive') {
flatList.scrollToOffset({ offset: 0, animated: true });
}
}
render() { render() {
return this.props.chatThreadList; return this.props.chatThreadList;
} }
flatListRef = (flatList: ?FlatList<Item>) => { flatListRef = (flatList: ?FlatList<Item>) => {
this.flatList = flatList; this.flatList = flatList;
}; };
} }
▲ Show 20 Lines • Show All 412 Lines • ▼ Show 20 Linesfunction ConnectedChatThreadList(props: BaseProps): React.Node {
React.useEffect(() => { React.useEffect(() => {
BackHandler.addEventListener('hardwareBackPress', hardwareBack); BackHandler.addEventListener('hardwareBackPress', hardwareBack);
return () => { return () => {
BackHandler.removeEventListener('hardwareBackPress', hardwareBack); BackHandler.removeEventListener('hardwareBackPress', hardwareBack);
}; };
}, [hardwareBack]); }, [hardwareBack]);
const isActiveOrActivating =
searchStatus === 'active' || searchStatus === 'activating';
React.useEffect(() => {
if (isActiveOrActivating) {
searchCancelButtonOpen.setValue(1);
} else {
searchCancelButtonOpen.setValue(0);
}
}, [isActiveOrActivating, searchCancelButtonOpen]);
React.useEffect(() => {
if (scrollPos.current > 0 && flatListRef.current) {
flatListRef.current.scrollToOffset({ offset: 0, animated: false });
}
}, [searchText]);
const isSearchActivating = searchStatus === 'activating';
React.useEffect(() => {
if (isSearchActivating && scrollPos.current > 0 && flatListRef.current) {
flatListRef.current.scrollToOffset({ offset: 0, animated: true });
}
}, [isSearchActivating]);
return ( return (
<ChatThreadList <ChatThreadList
navigation={navigation} navigation={navigation}
route={route} route={route}
filterThreads={filterThreads} filterThreads={filterThreads}
emptyItem={emptyItem} emptyItem={emptyItem}
searchText={searchText} searchText={searchText}
searchStatus={searchStatus} searchStatus={searchStatus}
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines
View Options

services/identity/src/main.rs

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Lines
class ChatThreadList extends React.PureComponent<Props> { class ChatThreadList extends React.PureComponent<Props> {
flatList: ?FlatList<Item>; flatList: ?FlatList<Item>;
constructor(props: Props) { constructor(props: Props) {
super(props); super(props);
} }
componentDidUpdate(prevProps: Props) {
const { searchStatus } = this.props;
const prevSearchStatus = prevProps.searchStatus;
const isActiveOrActivating =
searchStatus === 'active' || searchStatus === 'activating';
const wasActiveOrActivating =
prevSearchStatus === 'active' || prevSearchStatus === 'activating';
if (isActiveOrActivating && !wasActiveOrActivating) {
this.props.searchCancelButtonOpen.setValue(1);
} else if (!isActiveOrActivating && wasActiveOrActivating) {
this.props.searchCancelButtonOpen.setValue(0);
}
const { flatList } = this;
if (!flatList) {
return;
}
if (this.props.searchText !== prevProps.searchText) {
flatList.scrollToOffset({ offset: 0, animated: false });
return;
}
if (searchStatus === 'activating' && prevSearchStatus === 'inactive') {
flatList.scrollToOffset({ offset: 0, animated: true });
}
}
render() { render() {
return this.props.chatThreadList; return this.props.chatThreadList;
} }
flatListRef = (flatList: ?FlatList<Item>) => { flatListRef = (flatList: ?FlatList<Item>) => {
this.flatList = flatList; this.flatList = flatList;
}; };
} }
▲ Show 20 Lines • Show All 412 Lines • ▼ Show 20 Linesfunction ConnectedChatThreadList(props: BaseProps): React.Node {
React.useEffect(() => { React.useEffect(() => {
BackHandler.addEventListener('hardwareBackPress', hardwareBack); BackHandler.addEventListener('hardwareBackPress', hardwareBack);
return () => { return () => {
BackHandler.removeEventListener('hardwareBackPress', hardwareBack); BackHandler.removeEventListener('hardwareBackPress', hardwareBack);
}; };
}, [hardwareBack]); }, [hardwareBack]);
const isActiveOrActivating =
searchStatus === 'active' || searchStatus === 'activating';
React.useEffect(() => {
if (isActiveOrActivating) {
searchCancelButtonOpen.setValue(1);
} else {
searchCancelButtonOpen.setValue(0);
}
}, [isActiveOrActivating, searchCancelButtonOpen]);
React.useEffect(() => {
if (scrollPos.current > 0 && flatListRef.current) {
flatListRef.current.scrollToOffset({ offset: 0, animated: false });
}
}, [searchText]);
const isSearchActivating = searchStatus === 'activating';
React.useEffect(() => {
if (isSearchActivating && scrollPos.current > 0 && flatListRef.current) {
flatListRef.current.scrollToOffset({ offset: 0, animated: true });
}
}, [isSearchActivating]);
return ( return (
<ChatThreadList <ChatThreadList
navigation={navigation} navigation={navigation}
route={route} route={route}
filterThreads={filterThreads} filterThreads={filterThreads}
emptyItem={emptyItem} emptyItem={emptyItem}
searchText={searchText} searchText={searchText}
searchStatus={searchStatus} searchStatus={searchStatus}
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines
View Options

services/identity/src/token.rs

Loading...