Details
- Reviewers
bartek • patryk kamil • jon - Commits
- rCOMM53fa1c4eaf6e: [Backup] Old backup cleanup
Run integration tests
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
services/backup/src/database/mod.rs | ||
---|---|---|
182–183 ↗ | (On Diff #30427) | From query documentation: "Query results are always sorted by the sort key value" ...although later in the same paragraph they say "To reverse the order, set the ScanIndexForward parameter to false.", which wasn't correct in my experience (in both cases the order was the same). I will implement your second suggestion. |
186–195 ↗ | (On Diff #30427) | We need the returned values to cleanup user_data (it's only in the full backup table and not in index). Barring any errors, there should always be only one backup (the previous one) that is being deleted anyway. |
services/backup/src/database/mod.rs | ||
---|---|---|
182–183 ↗ | (On Diff #30427) |
Yes, that's why I'm asking |
Rebase, improve how we skip the latest backup when removing old backups (search for the backup with max creation time)