Differential D9054
[native] Add more memoization to `SwipeableMessage` Authored by atul on Aug 31 2023, 9:56 AM. Tags None Referenced Files
Subscribers
Details As mentioned in D9053, SwipeableMessage is "expensive" to render. As I've been looking through the flamegraphs it seems like a general trend that gesture handlers/Reanimated components are expensive to render and we should memoize as agressively as possible so we only "eat the cost" once. In this diff I add more memoization to SwipeableMessage to reduce re-renders of the nested SwipeSnake and PanGestureHandler components. Depends on D9053 Things continue to work as expected, profiler confirmed that this reduced re-renders.
Diff Detail
Event TimelineComment Actions  Okay looks like that stopped re-render of one of the SwipeSnakes, but we still have another SwipeSnake and panGestureHandler re-rendering.. will take another look and update Test Plan with before/after flamegraphs (As an aside, love that I can validate whether changes are effective w/ the profiler instead of just going off of often mistaken instinct) Comment Actions a little more memoization. i think i'm going to "call this diff" for now. the core issue is the children React.Node that gets drilled down that contains InnerTextMessage. I'll need to memoize that "futher up the component tree" to really make an impact Comment Actions Shouldn't this diff have a dependency on D9053? Also, the test plan seems to be incomplete
The code looks ok, but I'm not sure if all the memoizations introduced here are really beneficial.
| |||||||||||||||||||||||||||||||||||||||||||||||||