Page MenuHomePhabricator
Differential D9076

[native] expose prekey generation to js
ClosedPublic
Actions

Authored by varun on Sep 4 2023, 9:37 PM.
Tags
None
Referenced Files
F3388445: D9076.id30740.diff
Fri, Nov 29, 2:22 PM
Unknown Object (File)
Fri, Nov 22, 7:10 PM
Unknown Object (File)
Fri, Nov 22, 2:29 PM
Unknown Object (File)
Sat, Nov 9, 11:41 AM
Unknown Object (File)
Sat, Nov 9, 11:41 AM
Unknown Object (File)
Sat, Nov 9, 11:41 AM
Unknown Object (File)
Fri, Nov 8, 8:08 AM
Unknown Object (File)
Oct 28 2024, 1:24 PM
View All 71 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
marcin
Commits
rCOMM6b237d1978ae: [native] expose prekey generation to js
Summary

we want to send a contentPrekey and a notificationPrekey to the identity service on registration

Test Plan

console.log(await commCoreModule.generateAndGetPrekey()) returns a prekey string

Diff Detail

Repository
rCOMM Comm
Branch
native (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Sep 4 2023, 9:37 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 4 2023, 9:37 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 4 2023, 9:54 PM
Harbormaster failed remote builds in B22372: Diff 30739!
varun added a comment.Sep 4 2023, 10:18 PM

console.log output:

{"curve25519":{"AAAAAg":"sexB8fblTCASSVSMtKkcVsLHbheayl11uH76AQO33h4"}}
varun updated this revision to Diff 30740.Sep 4 2023, 10:18 PM

fix iOS build

Harbormaster completed remote builds in B22373: Diff 30740.Sep 4 2023, 10:36 PM
varun requested review of this revision.Sep 4 2023, 10:36 PM
marcin accepted this revision.Sep 5 2023, 1:50 AM
varun added a child revision: D9083: [native] generateAndGetNotificationsPrekey.Sep 5 2023, 6:07 AM
marcin added inline comments.Sep 6 2023, 1:39 AM
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
531 ↗(On Diff #30740)

I would name this method generateAndGetContentPrekey to avoid confusion.

atul accepted this revision.Sep 6 2023, 2:03 PM

Seems reasonable, defer to @marcin since he has more context

This revision is now accepted and ready to land.Sep 6 2023, 2:03 PM
varun added inline comments.Sep 8 2023, 8:52 AM
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
531 ↗(On Diff #30740)

in a later diff I change this method to return both prekeys and their respective signatures. renamed it to generateAndGetPrekeys at that point

Closed by commit rCOMM6b237d1978ae: [native] expose prekey generation to js (authored by varun). · Explain WhySep 12 2023, 12:54 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM6b237d1978ae: [native] expose prekey generation to js.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
1 line
24 lines
_generated/
schema/
1 line

Diff 30739

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...