Page MenuHomePhabricator
Differential D9127

[native] rename fields in JSON serialized string to camelCase from snake_case
ClosedPublic
Actions

Authored by varun on Sep 11 2023, 7:42 AM.
Tags
None
Referenced Files
F3348583: D9127.id30931.diff
Fri, Nov 22, 3:16 PM
F3346833: D9127.diff
Fri, Nov 22, 10:01 AM
Unknown Object (File)
Wed, Nov 6, 4:27 AM
Unknown Object (File)
Wed, Nov 6, 4:27 AM
Unknown Object (File)
Wed, Nov 6, 4:26 AM
Unknown Object (File)
Wed, Nov 6, 4:22 AM
Unknown Object (File)
Oct 2 2024, 9:14 PM
Unknown Object (File)
Sep 27 2024, 10:27 PM
View All 93 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
kamil
Commits
rCOMMace6020e7439: [native] rename fields in JSON serialized string to camelCase from snake_case
Summary

when we serialize objects in Rust we should use camelCase naming to match JS conventions

Test Plan

called registerUser from JS and the JSON string that I got back had the correct field names

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Sep 11 2023, 7:42 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 11 2023, 7:42 AM
Harbormaster completed remote builds in B22499: Diff 30931.Sep 11 2023, 8:00 AM
varun requested review of this revision.Sep 11 2023, 8:00 AM
varun added inline comments.Sep 11 2023, 10:33 AM
native/native_rust_library/src/lib.rs
215 ↗(On Diff #30931)

will change this to userID

varun added a child revision: D9129: [lib] utility function to get array of OneTimeKeys from an OLMOneTimeKeys object.Sep 11 2023, 10:37 AM
varun added a parent revision: D9115: [lib] move a shared type to lib.Sep 11 2023, 10:38 AM
bartek accepted this revision.Sep 12 2023, 12:16 AM
bartek added inline comments.
native/native_rust_library/src/lib.rs
213–219 ↗(On Diff #30931)

I prefer this way - it's more universal

This revision is now accepted and ready to land.Sep 12 2023, 12:16 AM
kamil accepted this revision.Sep 12 2023, 12:30 AM
kamil added inline comments.
native/native_rust_library/src/lib.rs
213–219 ↗(On Diff #30931)

+1

Closed by commit rCOMMace6020e7439: [native] rename fields in JSON serialized string to camelCase from snake_case (authored by varun). · Explain WhySep 13 2023, 11:18 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMace6020e7439: [native] rename fields in JSON serialized string to camelCase from snake_case.

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
src/
2 lines

Diff 31084

View Options

native/native_rust_library/src/lib.rs

Loading...