Page MenuHomePhabricator
Differential D9212

[native] Consume `useThreadListSearch` in `ChatThreadList`
ClosedPublic
Actions

Authored by atul on Sep 14 2023, 3:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 2:07 AM
Unknown Object (File)
Nov 24 2024, 11:26 AM
Unknown Object (File)
Nov 24 2024, 11:25 AM
Unknown Object (File)
Nov 24 2024, 11:07 AM
Unknown Object (File)
Nov 24 2024, 10:59 AM
Unknown Object (File)
Nov 21 2024, 2:14 PM
Unknown Object (File)
Nov 20 2024, 3:47 PM
Unknown Object (File)
Nov 15 2024, 4:24 AM
View All Files
Subscribers
ashoat
• jacek

Details

Reviewers
ginsu
tomek
rohan
Commits
rCOMM74c8424f88cc: [native] Consume `useThreadListSearch` in `ChatThreadList`
Summary

Huge shoutout @jacek for giving us the gift of useThreadListSearch which we're able to just seamlessly drop into ChatThreadList. This further helps reduce the number of ChatThreadList re-renders.

We're getting closer, but there's still some more work to get to no re-renders of ChatThreadList when we navigate to MessageList from ThreadList...

Depends on D9211

Test Plan

Search experience continues to look and work as expected. Set logs in all expected callbacks to ensure that they fired as expected. Made sure that x-icon and "Cancel" button continue to look and behave as before.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Sep 14 2023, 3:51 PM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 14 2023, 3:51 PM
Harbormaster completed remote builds in B22647: Diff 31158.Sep 14 2023, 4:09 PM
atul requested review of this revision.Sep 14 2023, 4:09 PM
atul added a child revision: D9213: [native] Memoize `ThreadAncestorsLabel`.Sep 14 2023, 7:33 PM
rohan accepted this revision.Sep 15 2023, 2:28 PM

Nice to see the code a lot simpler!

native/chat/chat-thread-list-search.react.js
20 ↗(On Diff #31158)

Not 100% though, cc @ginsu since he's brought it up recently

This revision is now accepted and ready to land.Sep 15 2023, 2:28 PM
atul updated this revision to Diff 31217.Sep 18 2023, 10:32 AM

rebase

Harbormaster completed remote builds in B22689: Diff 31217.Sep 18 2023, 10:50 AM
atul updated this revision to Diff 31230.Sep 18 2023, 1:48 PM

rebase around D9211 to land

This revision was landed with ongoing or failed builds.Sep 18 2023, 2:04 PM
Closed by commit rCOMM74c8424f88cc: [native] Consume `useThreadListSearch` in `ChatThreadList` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM74c8424f88cc: [native] Consume `useThreadListSearch` in `ChatThreadList`.
Harbormaster completed remote builds in B22697: Diff 31230.Sep 18 2023, 2:07 PM

Revision Contents
Changeset List

PathSize
native/
chat/
57 lines

Diff 31217

View Options

native/chat/chat-thread-list.react.js

Loading...