Page MenuHomePhabricator
Differential D9210

[native] Add some basic memoization to `ChatThreadListSearch`
ClosedPublic
Actions

Authored by atul on Sep 14 2023, 2:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 7:50 AM
Unknown Object (File)
Tue, Oct 29, 9:57 AM
Unknown Object (File)
Tue, Oct 29, 3:01 AM
Unknown Object (File)
Sun, Oct 27, 12:55 AM
Unknown Object (File)
Sun, Oct 27, 12:55 AM
Unknown Object (File)
Sun, Oct 27, 12:55 AM
Unknown Object (File)
Sun, Oct 27, 12:55 AM
Unknown Object (File)
Sun, Oct 27, 12:55 AM
View All Files
Subscribers
ashoat

Details

Reviewers
ginsu
tomek
rohan
Commits
rCOMM90f88e7b7c08: [native] Add some basic memoization to `ChatThreadListSearch`
Summary

Some straightforward memoization + removed some extraneous styles from both ChatThreadList and ChatThreadListSearch.

Depends on D9209

Test Plan

Search experience continues to look and work as expected. Set logs in all expected callbacks to ensure that they fired as expected. Made sure that x-icon and "Cancel" button continue to look and behave as before.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D9210_1 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Sep 14 2023, 2:16 PM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 14 2023, 2:16 PM
atul published this revision for review.Sep 14 2023, 2:16 PM
atul added a child revision: D9211: [native] Memoize `flatList` in `ChatThreadList`.Sep 14 2023, 2:22 PM
Harbormaster completed remote builds in B22645: Diff 31156.Sep 14 2023, 2:34 PM
tomek accepted this revision.Sep 18 2023, 6:01 AM
This revision is now accepted and ready to land.Sep 18 2023, 6:01 AM
atul updated this revision to Diff 31215.Sep 18 2023, 10:31 AM

rebase

Harbormaster completed remote builds in B22687: Diff 31215.Sep 18 2023, 10:48 AM
atul updated this revision to Diff 31228.Sep 18 2023, 1:45 PM

land

This revision was landed with ongoing or failed builds.Sep 18 2023, 1:46 PM
Closed by commit rCOMM90f88e7b7c08: [native] Add some basic memoization to `ChatThreadListSearch` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM90f88e7b7c08: [native] Add some basic memoization to `ChatThreadListSearch`.
Harbormaster completed remote builds in B22696: Diff 31228.Sep 18 2023, 2:08 PM

Revision Contents
Changeset List

Diff 31228

View Options

native/chat/chat-thread-list-search.react.js

Loading...
View Options

native/chat/chat-thread-list.react.js

Loading...