Page MenuHomePhabricator
Differential D9379

[native] rename RelationshipListItemTooltipModal to UserRelationshipTooltipModal
ClosedPublic
Actions

Authored by ginsu on Oct 5 2023, 2:09 PM.
Tags
None
Referenced Files
F3348181: D9379.id31700.diff
Fri, Nov 22, 2:00 PM
F3346451: D9379.diff
Fri, Nov 22, 8:48 AM
Unknown Object (File)
Sat, Oct 26, 1:13 AM
Unknown Object (File)
Oct 21 2024, 4:29 AM
Unknown Object (File)
Oct 21 2024, 4:25 AM
Unknown Object (File)
Oct 20 2024, 7:58 PM
Unknown Object (File)
Oct 20 2024, 3:41 PM
Unknown Object (File)
Oct 20 2024, 3:41 PM
View All 74 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
Commits
rCOMM741de0af2fd4: [native] rename RelationshipListItemTooltipModal to UserRelationshipTooltipModal
Summary

Rename diff

This is step 2 in the list below
Outlined below are the steps I will take to update RelationshipListItemTooltipModal:

  1. Add the block action to relationship list item tooltip menu (RelationshipListItem won't need this option, but User profiles will. This is shown in the figma screenshot above)
  2. Rename RelationshipListItemTooltipModal to something more generic like UserRelationshipTooltipModal
  3. Make UserRelationshipTooltipButton into a functional component (We need to use the useColors hook in a subsequent diff)
  4. Introduce the tooltipButtonIcon as a param to RelationshipListItemTooltipModal (RelationshipListItem will use a pencil icon and user profiles will use a kebab menu icon)
  5. Introduce UserProfileMenuButton (This component will handle navigating to RelationshipListItemTooltipModal

Depends on D9378

Test Plan

flow and confirmed that I am able to still navigate to UserRelationshipTooltipModal when pressing the edit button in RelationshipListItem

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Oct 5 2023, 2:09 PM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 5 2023, 2:09 PM
ginsu edited the summary of this revision. (Show Details)Oct 5 2023, 2:13 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D9378: [native] introduce block action to relationship list item tooltip menu.
Harbormaster completed remote builds in B23020: Diff 31700.Oct 5 2023, 2:28 PM
ginsu requested review of this revision.Oct 5 2023, 2:28 PM
ginsu added a child revision: D9380: [native] make UserRelationshipTooltipButton a functional component.Oct 5 2023, 2:30 PM
atul accepted this revision.Oct 5 2023, 4:26 PM

Looks like straightforward find+replace

This revision is now accepted and ready to land.Oct 5 2023, 4:26 PM
ginsu updated this revision to Diff 31715.Oct 5 2023, 6:29 PM
ginsu edited the test plan for this revision. (Show Details)

rebase before landing

This revision was landed with ongoing or failed builds.Oct 5 2023, 6:38 PM
Closed by commit rCOMM741de0af2fd4: [native] rename RelationshipListItemTooltipModal to UserRelationshipTooltipModal (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM741de0af2fd4: [native] rename RelationshipListItemTooltipModal to UserRelationshipTooltipModal.
Harbormaster completed remote builds in B23035: Diff 31715.Oct 5 2023, 6:49 PM

Revision Contents
Changeset List

PathSize
native/
navigation/
8 lines
10 lines
profile/
6 lines
user-relationship-tooltip-modal.react.js
relationship-list-item-tooltip-modal.react.js
21 lines

Diff 31700

View Options

native/navigation/app-navigator.react.js

Loading...
View Options

native/navigation/route-names.js

Loading...
View Options

native/profile/relationship-list-item-tooltip-modal.react.js

Loading...
View Options

native/profile/relationship-list-item.react.js

Loading...
View Options

native/profile/user-relationship-tooltip-modal.react.js

Loading...