[Tunnelbroker] generate client message ID for gRPC messages
ClosedPublic
Actions

Authored by kamil on Oct 12 2023, 4:21 AM.

Details

Reviewers

michal
bartek
varun
• jon

Commits

rCOMM9fc00a03c380: [Tunnelbroker] generate client message ID for gRPC messages

Summary

Issue: ENG-5149.

Protocol diagram: notion doc.

For gRPC calls we need to generate ID directly on Tunnelbroker to keep schema consistent.

Depends on D9459

Test Plan

Send gRPC message and make sure it is properly persisted in DDB.
[ss]

Diff Detail

Repository

rCOMM Comm

Branch

tb-work-2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Oct 12 2023, 4:21 AM

kamil held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptOct 12 2023, 4:21 AM

Herald added subscribers: will, tomek, ashoat. · View Herald Transcript

kamil added a child revision: D9461: [Tunnelbroker] handle all types of socket messages.Oct 12 2023, 4:33 AM

Harbormaster completed remote builds in B23206: Diff 31958.Oct 12 2023, 4:39 AM

kamil published this revision for review.Oct 12 2023, 8:13 AM

kamil mentioned this in D9459: [Tunnelbroker] update DDB schema to handle client message ID.

bartek accepted this revision.Oct 13 2023, 3:22 AM

This revision is now accepted and ready to land.Oct 13 2023, 3:22 AM

michal accepted this revision.Oct 13 2023, 6:36 AM

Closed by commit rCOMM9fc00a03c380: [Tunnelbroker] generate client message ID for gRPC messages (authored by kamil). · Explain WhyOct 18 2023, 3:09 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM9fc00a03c380: [Tunnelbroker] generate client message ID for gRPC messages.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

Cargo.lock

Cargo.toml

1 line

src/

grpc/

mod.rs

4 lines

Diff 31958

View Options

services/tunnelbroker/Cargo.lock

View Options

services/tunnelbroker/Cargo.toml

View Options

services/tunnelbroker/src/grpc/mod.rs

[Tunnelbroker] generate client message ID for gRPC messagesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31958

services/tunnelbroker/Cargo.lock

services/tunnelbroker/Cargo.toml

services/tunnelbroker/src/grpc/mod.rs

[Tunnelbroker] generate client message ID for gRPC messages
ClosedPublic
Actions

Revision Contents
Changeset List