Differential D9470

[native] use grpc_clients client in native_rust_library
ClosedPublic
Actions

Authored by varun on Oct 12 2023, 10:24 AM.

Tags

None

Referenced Files

	F3201336: D9470.diff
	Sat, Nov 9, 4:11 PM

	Unknown Object (File)
	Wed, Oct 30, 7:24 AM

	Unknown Object (File)
	Wed, Oct 30, 7:24 AM

	Unknown Object (File)
	Wed, Oct 30, 7:24 AM

	Unknown Object (File)
	Wed, Oct 30, 7:22 AM

	Unknown Object (File)
	Sep 26 2024, 5:24 PM

	Unknown Object (File)
	Sep 23 2024, 12:43 PM

	Unknown Object (File)
	Sep 19 2024, 6:01 PM

View All 62 Files

Subscribers

Details

Reviewers

bartek
michal

Commits

rCOMMe346fcf9347a: [native] use grpc_clients client in native_rust_library

Summary

replaced the old grpc clients with the new one with an interceptor from shared/grpc_clients. i also updated build.rs to get the codeVersion from CommCoreModule.h. lastly, i removed unused dependencies and dead code.

Test Plan

unit tested the code version change
sent a request to local identity service from native_rust_library and verified the request was received and contained the code version metadata
built the native app for iOS simulator successfully

Diff Detail

Repository

Branch

alchemy (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Oct 12 2023, 10:24 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 12 2023, 10:24 AM

varun added reviewers: bartek, michal.Oct 12 2023, 10:31 AM

Harbormaster completed remote builds in B23217: Diff 31972.Oct 12 2023, 10:43 AM

varun requested review of this revision.Oct 12 2023, 10:43 AM

varun added a child revision: D9471: [keyserver] clippy fixes.Oct 12 2023, 11:54 AM

bartek accepted this revision.Oct 16 2023, 12:38 AM

bartek added inline comments.

native/native_rust_library/build.rs
11	This can be moved to the bottom of this fn, to the other similar call

This revision is now accepted and ready to land.Oct 16 2023, 12:38 AM

Closed by commit rCOMMe346fcf9347a: [native] use grpc_clients client in native_rust_library (authored by varun). · Explain WhyOct 18 2023, 8:00 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMe346fcf9347a: [native] use grpc_clients client in native_rust_library.

varun added a reverting change: rCOMM06ac983154f3: Revert "[native] use grpc_clients client in native_rust_library".Oct 19 2023, 7:58 AM

varun mentioned this in D9602: [CI] fix iOS build issue following D9470.Oct 25 2023, 4:22 PM

varun mentioned this in rCOMMedcd02905c56: [CI] fix iOS build issue following D9470.Oct 26 2023, 9:25 AM

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

6 lines

52 lines

src/

identity_client.rs

106 lines

Diff 31972

native/native_rust_library/Cargo.lock

Loading...

native/native_rust_library/Cargo.toml

Loading...

native/native_rust_library/build.rs

Loading...

native/native_rust_library/src/identity_client.rs

Loading...

native/native_rust_library/src/lib.rs

Loading...