Page MenuHomePhabricator

[native] use grpc_clients client in native_rust_library
ClosedPublic

Authored by varun on Oct 12 2023, 10:24 AM.
Tags
None
Referenced Files
F3360911: D9470.id31972.diff
Sun, Nov 24, 2:42 PM
F3360817: D9470.id32162.diff
Sun, Nov 24, 2:35 PM
F3359909: D9470.diff
Sun, Nov 24, 11:37 AM
Unknown Object (File)
Sat, Nov 9, 7:38 PM
Unknown Object (File)
Sat, Nov 9, 4:11 PM
Unknown Object (File)
Wed, Oct 30, 7:24 AM
Unknown Object (File)
Wed, Oct 30, 7:24 AM
Unknown Object (File)
Wed, Oct 30, 7:24 AM
Subscribers

Details

Summary

replaced the old grpc clients with the new one with an interceptor from shared/grpc_clients. i also updated build.rs to get the codeVersion from CommCoreModule.h. lastly, i removed unused dependencies and dead code.

Test Plan
  • unit tested the code version change
  • sent a request to local identity service from native_rust_library and verified the request was received and contained the code version metadata
  • built the native app for iOS simulator successfully

Diff Detail

Repository
rCOMM Comm
Branch
alchemy (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek added inline comments.
native/native_rust_library/build.rs
11

This can be moved to the bottom of this fn, to the other similar call

This revision is now accepted and ready to land.Oct 16 2023, 12:38 AM