Paths

Table of Contentst

[lib] Remove setCookieOnRequest
ClosedPublic
Actions

Authored by michal on Oct 16 2023, 12:35 PM.

Details

Reviewers

inka
kamil
atul
ashoat

Commits

rCOMMa689d2faedcc: [lib] Remove setCookieOnRequest

Summary

ENG-4747
Depends on D9290

After D9288 both web and native had this config set to true so we can remove it and simplify the code.

Test Plan

yarn flow-all

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Oct 16 2023, 12:35 PM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 16 2023, 12:35 PM

Harbormaster completed remote builds in B23263: Diff 32036.Oct 16 2023, 12:53 PM

michal requested review of this revision.Oct 16 2023, 12:53 PM

Accepting, but adding @ashoat as blocking to take another look

ashoat accepted this revision.Oct 18 2023, 8:41 PM

ashoat added inline comments.

lib/utils/call-server-endpoint.js
78–84	Thanks for finding / deleting this comment

This revision is now accepted and ready to land.Oct 18 2023, 8:41 PM

Closed by commit rCOMMa689d2faedcc: [lib] Remove setCookieOnRequest. · Explain WhyOct 23 2023, 10:05 AM

This revision was automatically updated to reflect the committed changes.

Restricted Repository Identity added a commit: rCOMMa689d2faedcc: [lib] Remove setCookieOnRequest.

Revision Contents
Changeset List

Path

Size

lib/

utils/

call-server-endpoint.js

17 lines

config.js

1 line

upload-blob.js

10 lines

native/

config.js

1 line

web/

app.react.js

1 line

Diff 32036

View Options

lib/utils/call-server-endpoint.js

View Options

lib/utils/config.js

View Options

lib/utils/upload-blob.js

View Options

native/config.js

View Options

[lib] Remove setCookieOnRequestClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 32036

lib/utils/call-server-endpoint.js

lib/utils/config.js

lib/utils/upload-blob.js

native/config.js

web/app.react.js

[lib] Remove setCookieOnRequest
ClosedPublic
Actions

Revision Contents
Changeset List