Paths

Table of Contentst

Differential D9462

[Tunnelbroker] add MessageToDeviceRequest message
ClosedPublic
Actions

Authored by kamil on Oct 12 2023, 4:56 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 10, 10:35 AM

	Unknown Object (File)
	Sun, Nov 10, 5:01 AM

	Unknown Object (File)
	Sat, Nov 9, 9:53 AM

	Unknown Object (File)
	Sat, Nov 9, 9:42 AM

	Unknown Object (File)
	Sat, Nov 9, 8:39 AM

	Unknown Object (File)
	Sat, Nov 9, 4:46 AM

	Unknown Object (File)
	Fri, Oct 18, 9:02 PM

	Unknown Object (File)
	Oct 2 2024, 1:06 PM

View All 83 Files

Subscribers

Details

Reviewers

michal
bartek
varun
• jon

Commits

rCOMMa58cd93b9140: [Tunnelbroker] add MessageToDeviceRequest message

Summary

Issue: ENG-5149.

Protocol diagram: notion doc.

We want to send request to Tunnelbroker to send message to device.
We add clientMessageID because Tunnelbroker has to know which message to confirm later.
Using clientMessageID - not simple messageID because Tunnelbroker will assign another ID based od timestamp (messages needs to be sorted).
Adding this ID will also fix problem when two separate Tunnelbroker instances will get message for the same recipient in exactly the same time.

Depends on D9461

Test Plan

Run tests (both message and Tunnelbroker integration tests)

Diff Detail

Repository

Branch

tb-work-3

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Oct 12 2023, 4:56 AM

kamil held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptOct 12 2023, 4:56 AM

Herald added subscribers: will, tomek, ashoat. · View Herald Transcript

kamil added a child revision: D9463: [Tunnelbroker] add MessageToDeviceRequestStatus message.Oct 12 2023, 5:10 AM

Harbormaster completed remote builds in B23208: Diff 31960.Oct 12 2023, 5:14 AM

kamil published this revision for review.Oct 12 2023, 8:13 AM

kamil mentioned this in D9459: [Tunnelbroker] update DDB schema to handle client message ID.

michal accepted this revision.Oct 13 2023, 7:07 AM

michal added inline comments.

services/tunnelbroker/src/websockets/session.rs
171–173 ↗	(On Diff #31960)	Not directly related to the diff but I find this easier to read
shared/tunnelbroker_messages/src/messages/mod.rs
19 ↗	(On Diff #31960)	I remember we talked about weird serde behaviour with ordering of the enum variants. Do you think it would be worth to add a code comment for this?

This revision is now accepted and ready to land.Oct 13 2023, 7:07 AM

address review

services/tunnelbroker/src/websockets/session.rs
171–173 ↗	(On Diff #31960)	adressed here
shared/tunnelbroker_messages/src/messages/mod.rs
19 ↗	(On Diff #31960)	right, added

Harbormaster completed remote builds in B23322: Diff 32132.Oct 18 2023, 1:24 AM

Closed by commit rCOMMa58cd93b9140: [Tunnelbroker] add MessageToDeviceRequest message (authored by kamil). · Explain WhyOct 18 2023, 3:10 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa58cd93b9140: [Tunnelbroker] add MessageToDeviceRequest message.

Revision Contents
Changeset List

Path

Size

services/

commtest/

tests/

tunnelbroker_integration_tests.rs

13 lines

tunnelbroker_persist_tests.rs

7 lines

tunnelbroker/

src/

websockets/

17 lines

shared/

tunnelbroker_messages/

src/

messages/

message_to_device_request.rs

34 lines

8 lines

2 lines

Diff 32132

services/commtest/tests/tunnelbroker_integration_tests.rs

Loading...

services/commtest/tests/tunnelbroker_persist_tests.rs

Loading...

services/tunnelbroker/src/websockets/session.rs

Loading...

shared/tunnelbroker_messages/src/messages/message_to_device_request.rs

Loading...

shared/tunnelbroker_messages/src/messages/mod.rs

Loading...

shared/tunnelbroker_messages/src/messages/session.rs

Loading...