Page MenuHomePhabricator

[Tunnelbroker] handle all types of socket messages
ClosedPublic

Authored by kamil on Oct 12 2023, 4:33 AM.
Tags
None
Referenced Files
F3273872: D9461.diff
Sat, Nov 16, 6:22 AM
Unknown Object (File)
Sat, Nov 9, 9:53 AM
Unknown Object (File)
Sat, Nov 9, 9:44 AM
Unknown Object (File)
Sat, Nov 9, 8:39 AM
Unknown Object (File)
Sat, Nov 9, 4:46 AM
Unknown Object (File)
Fri, Oct 18, 9:02 PM
Unknown Object (File)
Oct 2 2024, 1:06 PM
Unknown Object (File)
Oct 2 2024, 1:06 PM
Subscribers

Details

Summary

This is an enhancement, we should handle those messages properly.

Ping/Pong should be handled automatically, eg. You can send a ping message to WebSocket created with ws which we use on Keyserver, and pong will be sent implicitly, even if it's not implemented in the top level.

Based on the tool we now plan to use this is not super needed but it's better to avoid closing a socket when the client library/tool sends a ping.

Test Plan

Run tests, and verify those tests test it by checking Tunnelbroker logs.

Depends on D9460

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil retitled this revision from [Tunnelbroker] handle all type of socket messages to [Tunnelbroker] handle all types of socket messages.Oct 12 2023, 4:33 AM
kamil published this revision for review.Oct 12 2023, 8:14 AM
bartek added inline comments.
services/commtest/tests/tunnelbroker_websocket_messages_tests.rs
22–24 ↗(On Diff #31959)

Up to you - I like knowing what's wrong but this is less readable

This revision is now accepted and ready to land.Oct 13 2023, 3:33 AM

improve debug

services/commtest/tests/tunnelbroker_websocket_messages_tests.rs
22–24 ↗(On Diff #31959)

valid point, it's better to know what went wrong