Page MenuHomePhabricator
Differential D9530

[lib/naitve] lift update theme info action type into lib
ClosedPublic
Actions

Authored by ginsu on Oct 18 2023, 9:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 16, 4:06 PM
Unknown Object (File)
Wed, Apr 16, 12:24 PM
Unknown Object (File)
Wed, Apr 16, 3:27 AM
Unknown Object (File)
Tue, Apr 15, 10:55 PM
Unknown Object (File)
Mon, Apr 14, 9:45 PM
Unknown Object (File)
Wed, Apr 9, 7:37 AM
Unknown Object (File)
Thu, Apr 3, 10:46 PM
Unknown Object (File)
Mar 19 2025, 12:03 PM
View All 84 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
rohan
Commits
rCOMM6d63cec0abc8: [lib/naitve] lift update theme info action type into lib
Summary

Now that we want to bring updateThemeInfo redux actions/state into web as well there are several things we should lift from native into lib so that we can share them across both platforms. This diff lifts the updateThemeInfoActionType and adds this action type to redux-types in lib

Part of https://linear.app/comm/issue/ENG-4956/lift-any-necessary-shared-types-selectors-functions-for-storing-the

Depends on D9529

Test Plan

flow and confirmed that updating the app theme on native still works as expected

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
actions/
5 lines
types/
5 lines
native/
profile/
2 lines
redux/
6 lines
2 lines
3 lines
themes/
2 lines

Diff 32174

View Options

lib/actions/theme-actions.js

Show First 20 Lines • Show All 137 Lines • ▼ Show 20 Lines const threadInfo: LegacyRawThreadInfo =
updatedThreadStoreInfos[node.threadID]; updatedThreadStoreInfos[node.threadID];
let memberToThreadPermissionsForChildren: { let memberToThreadPermissionsForChildren: {
[string]: ?ThreadPermissionsBlob, [string]: ?ThreadPermissionsBlob,
}; };
if (threadInfo.thick) { if (threadInfo.thick) {
const { const {
members: updatedMembers, members: updatedMembers,
memberToThreadPermissionsForChildren: test, memberToThreadPermissionsForChildren:
updatedMemberToThreadPermissionsForChildren,
} = updateMembers<ThickMemberInfo>( } = updateMembers<ThickMemberInfo>(
threadInfo, threadInfo,
threadInfo.members, threadInfo.members,
memberToThreadPermissionsFromParent, memberToThreadPermissionsFromParent,
); );
updatedThreadStoreInfos[node.threadID] = { updatedThreadStoreInfos[node.threadID] = {
...threadInfo, ...threadInfo,
members: updatedMembers, members: updatedMembers,
}; };
memberToThreadPermissionsForChildren = test; memberToThreadPermissionsForChildren =
updatedMemberToThreadPermissionsForChildren;
} else { } else {
const { const {
members: updatedMembers, members: updatedMembers,
memberToThreadPermissionsForChildren: test, memberToThreadPermissionsForChildren:
updatedMemberToThreadPermissionsForChildren,
} = updateMembers<LegacyMemberInfo>( } = updateMembers<LegacyMemberInfo>(
threadInfo, threadInfo,
threadInfo.members, threadInfo.members,
memberToThreadPermissionsFromParent, memberToThreadPermissionsFromParent,
); );
updatedThreadStoreInfos[node.threadID] = { updatedThreadStoreInfos[node.threadID] = {
...threadInfo, ...threadInfo,
members: updatedMembers, members: updatedMembers,
}; };
memberToThreadPermissionsForChildren = test; memberToThreadPermissionsForChildren =
updatedMemberToThreadPermissionsForChildren;
} }
node.children?.map(child => node.children?.map(child =>
recursivelyUpdatePermissions(child, memberToThreadPermissionsForChildren), recursivelyUpdatePermissions(child, memberToThreadPermissionsForChildren),
); );
}; };
const recursivelyUpdateCurrentMemberPermissions = ( const recursivelyUpdateCurrentMemberPermissions = (
▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines
View Options

lib/types/redux-types.js

Show First 20 Lines • Show All 137 Lines • ▼ Show 20 Lines const threadInfo: LegacyRawThreadInfo =
updatedThreadStoreInfos[node.threadID]; updatedThreadStoreInfos[node.threadID];
let memberToThreadPermissionsForChildren: { let memberToThreadPermissionsForChildren: {
[string]: ?ThreadPermissionsBlob, [string]: ?ThreadPermissionsBlob,
}; };
if (threadInfo.thick) { if (threadInfo.thick) {
const { const {
members: updatedMembers, members: updatedMembers,
memberToThreadPermissionsForChildren: test, memberToThreadPermissionsForChildren:
updatedMemberToThreadPermissionsForChildren,
} = updateMembers<ThickMemberInfo>( } = updateMembers<ThickMemberInfo>(
threadInfo, threadInfo,
threadInfo.members, threadInfo.members,
memberToThreadPermissionsFromParent, memberToThreadPermissionsFromParent,
); );
updatedThreadStoreInfos[node.threadID] = { updatedThreadStoreInfos[node.threadID] = {
...threadInfo, ...threadInfo,
members: updatedMembers, members: updatedMembers,
}; };
memberToThreadPermissionsForChildren = test; memberToThreadPermissionsForChildren =
updatedMemberToThreadPermissionsForChildren;
} else { } else {
const { const {
members: updatedMembers, members: updatedMembers,
memberToThreadPermissionsForChildren: test, memberToThreadPermissionsForChildren:
updatedMemberToThreadPermissionsForChildren,
} = updateMembers<LegacyMemberInfo>( } = updateMembers<LegacyMemberInfo>(
threadInfo, threadInfo,
threadInfo.members, threadInfo.members,
memberToThreadPermissionsFromParent, memberToThreadPermissionsFromParent,
); );
updatedThreadStoreInfos[node.threadID] = { updatedThreadStoreInfos[node.threadID] = {
...threadInfo, ...threadInfo,
members: updatedMembers, members: updatedMembers,
}; };
memberToThreadPermissionsForChildren = test; memberToThreadPermissionsForChildren =
updatedMemberToThreadPermissionsForChildren;
} }
node.children?.map(child => node.children?.map(child =>
recursivelyUpdatePermissions(child, memberToThreadPermissionsForChildren), recursivelyUpdatePermissions(child, memberToThreadPermissionsForChildren),
); );
}; };
const recursivelyUpdateCurrentMemberPermissions = ( const recursivelyUpdateCurrentMemberPermissions = (
▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines
View Options

native/profile/appearance-preferences.react.js

Show First 20 Lines • Show All 137 Lines • ▼ Show 20 Lines const threadInfo: LegacyRawThreadInfo =
updatedThreadStoreInfos[node.threadID]; updatedThreadStoreInfos[node.threadID];
let memberToThreadPermissionsForChildren: { let memberToThreadPermissionsForChildren: {
[string]: ?ThreadPermissionsBlob, [string]: ?ThreadPermissionsBlob,
}; };
if (threadInfo.thick) { if (threadInfo.thick) {
const { const {
members: updatedMembers, members: updatedMembers,
memberToThreadPermissionsForChildren: test, memberToThreadPermissionsForChildren:
updatedMemberToThreadPermissionsForChildren,
} = updateMembers<ThickMemberInfo>( } = updateMembers<ThickMemberInfo>(
threadInfo, threadInfo,
threadInfo.members, threadInfo.members,
memberToThreadPermissionsFromParent, memberToThreadPermissionsFromParent,
); );
updatedThreadStoreInfos[node.threadID] = { updatedThreadStoreInfos[node.threadID] = {
...threadInfo, ...threadInfo,
members: updatedMembers, members: updatedMembers,
}; };
memberToThreadPermissionsForChildren = test; memberToThreadPermissionsForChildren =
updatedMemberToThreadPermissionsForChildren;
} else { } else {
const { const {
members: updatedMembers, members: updatedMembers,
memberToThreadPermissionsForChildren: test, memberToThreadPermissionsForChildren:
updatedMemberToThreadPermissionsForChildren,
} = updateMembers<LegacyMemberInfo>( } = updateMembers<LegacyMemberInfo>(
threadInfo, threadInfo,
threadInfo.members, threadInfo.members,
memberToThreadPermissionsFromParent, memberToThreadPermissionsFromParent,
); );
updatedThreadStoreInfos[node.threadID] = { updatedThreadStoreInfos[node.threadID] = {
...threadInfo, ...threadInfo,
members: updatedMembers, members: updatedMembers,
}; };
memberToThreadPermissionsForChildren = test; memberToThreadPermissionsForChildren =
updatedMemberToThreadPermissionsForChildren;
} }
node.children?.map(child => node.children?.map(child =>
recursivelyUpdatePermissions(child, memberToThreadPermissionsForChildren), recursivelyUpdatePermissions(child, memberToThreadPermissionsForChildren),
); );
}; };
const recursivelyUpdateCurrentMemberPermissions = ( const recursivelyUpdateCurrentMemberPermissions = (
▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines
View Options

native/redux/action-types.js

Show First 20 Lines • Show All 137 Lines • ▼ Show 20 Lines const threadInfo: LegacyRawThreadInfo =
updatedThreadStoreInfos[node.threadID]; updatedThreadStoreInfos[node.threadID];
let memberToThreadPermissionsForChildren: { let memberToThreadPermissionsForChildren: {
[string]: ?ThreadPermissionsBlob, [string]: ?ThreadPermissionsBlob,
}; };
if (threadInfo.thick) { if (threadInfo.thick) {
const { const {
members: updatedMembers, members: updatedMembers,
memberToThreadPermissionsForChildren: test, memberToThreadPermissionsForChildren:
updatedMemberToThreadPermissionsForChildren,
} = updateMembers<ThickMemberInfo>( } = updateMembers<ThickMemberInfo>(
threadInfo, threadInfo,
threadInfo.members, threadInfo.members,
memberToThreadPermissionsFromParent, memberToThreadPermissionsFromParent,
); );
updatedThreadStoreInfos[node.threadID] = { updatedThreadStoreInfos[node.threadID] = {
...threadInfo, ...threadInfo,
members: updatedMembers, members: updatedMembers,
}; };
memberToThreadPermissionsForChildren = test; memberToThreadPermissionsForChildren =
updatedMemberToThreadPermissionsForChildren;
} else { } else {
const { const {
members: updatedMembers, members: updatedMembers,
memberToThreadPermissionsForChildren: test, memberToThreadPermissionsForChildren:
updatedMemberToThreadPermissionsForChildren,
} = updateMembers<LegacyMemberInfo>( } = updateMembers<LegacyMemberInfo>(
threadInfo, threadInfo,
threadInfo.members, threadInfo.members,
memberToThreadPermissionsFromParent, memberToThreadPermissionsFromParent,
); );
updatedThreadStoreInfos[node.threadID] = { updatedThreadStoreInfos[node.threadID] = {
...threadInfo, ...threadInfo,
members: updatedMembers, members: updatedMembers,
}; };
memberToThreadPermissionsForChildren = test; memberToThreadPermissionsForChildren =
updatedMemberToThreadPermissionsForChildren;
} }
node.children?.map(child => node.children?.map(child =>
recursivelyUpdatePermissions(child, memberToThreadPermissionsForChildren), recursivelyUpdatePermissions(child, memberToThreadPermissionsForChildren),
); );
}; };
const recursivelyUpdateCurrentMemberPermissions = ( const recursivelyUpdateCurrentMemberPermissions = (
▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines
View Options

native/redux/redux-setup.js

Show First 20 Lines • Show All 137 Lines • ▼ Show 20 Lines const threadInfo: LegacyRawThreadInfo =
updatedThreadStoreInfos[node.threadID]; updatedThreadStoreInfos[node.threadID];
let memberToThreadPermissionsForChildren: { let memberToThreadPermissionsForChildren: {
[string]: ?ThreadPermissionsBlob, [string]: ?ThreadPermissionsBlob,
}; };
if (threadInfo.thick) { if (threadInfo.thick) {
const { const {
members: updatedMembers, members: updatedMembers,
memberToThreadPermissionsForChildren: test, memberToThreadPermissionsForChildren:
updatedMemberToThreadPermissionsForChildren,
} = updateMembers<ThickMemberInfo>( } = updateMembers<ThickMemberInfo>(
threadInfo, threadInfo,
threadInfo.members, threadInfo.members,
memberToThreadPermissionsFromParent, memberToThreadPermissionsFromParent,
); );
updatedThreadStoreInfos[node.threadID] = { updatedThreadStoreInfos[node.threadID] = {
...threadInfo, ...threadInfo,
members: updatedMembers, members: updatedMembers,
}; };
memberToThreadPermissionsForChildren = test; memberToThreadPermissionsForChildren =
updatedMemberToThreadPermissionsForChildren;
} else { } else {
const { const {
members: updatedMembers, members: updatedMembers,
memberToThreadPermissionsForChildren: test, memberToThreadPermissionsForChildren:
updatedMemberToThreadPermissionsForChildren,
} = updateMembers<LegacyMemberInfo>( } = updateMembers<LegacyMemberInfo>(
threadInfo, threadInfo,
threadInfo.members, threadInfo.members,
memberToThreadPermissionsFromParent, memberToThreadPermissionsFromParent,
); );
updatedThreadStoreInfos[node.threadID] = { updatedThreadStoreInfos[node.threadID] = {
...threadInfo, ...threadInfo,
members: updatedMembers, members: updatedMembers,
}; };
memberToThreadPermissionsForChildren = test; memberToThreadPermissionsForChildren =
updatedMemberToThreadPermissionsForChildren;
} }
node.children?.map(child => node.children?.map(child =>
recursivelyUpdatePermissions(child, memberToThreadPermissionsForChildren), recursivelyUpdatePermissions(child, memberToThreadPermissionsForChildren),
); );
}; };
const recursivelyUpdateCurrentMemberPermissions = ( const recursivelyUpdateCurrentMemberPermissions = (
▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines
View Options

native/redux/theme-reducer.js

Show First 20 Lines • Show All 137 Lines • ▼ Show 20 Lines const threadInfo: LegacyRawThreadInfo =
updatedThreadStoreInfos[node.threadID]; updatedThreadStoreInfos[node.threadID];
let memberToThreadPermissionsForChildren: { let memberToThreadPermissionsForChildren: {
[string]: ?ThreadPermissionsBlob, [string]: ?ThreadPermissionsBlob,
}; };
if (threadInfo.thick) { if (threadInfo.thick) {
const { const {
members: updatedMembers, members: updatedMembers,
memberToThreadPermissionsForChildren: test, memberToThreadPermissionsForChildren:
updatedMemberToThreadPermissionsForChildren,
} = updateMembers<ThickMemberInfo>( } = updateMembers<ThickMemberInfo>(
threadInfo, threadInfo,
threadInfo.members, threadInfo.members,
memberToThreadPermissionsFromParent, memberToThreadPermissionsFromParent,
); );
updatedThreadStoreInfos[node.threadID] = { updatedThreadStoreInfos[node.threadID] = {
...threadInfo, ...threadInfo,
members: updatedMembers, members: updatedMembers,
}; };
memberToThreadPermissionsForChildren = test; memberToThreadPermissionsForChildren =
updatedMemberToThreadPermissionsForChildren;
} else { } else {
const { const {
members: updatedMembers, members: updatedMembers,
memberToThreadPermissionsForChildren: test, memberToThreadPermissionsForChildren:
updatedMemberToThreadPermissionsForChildren,
} = updateMembers<LegacyMemberInfo>( } = updateMembers<LegacyMemberInfo>(
threadInfo, threadInfo,
threadInfo.members, threadInfo.members,
memberToThreadPermissionsFromParent, memberToThreadPermissionsFromParent,
); );
updatedThreadStoreInfos[node.threadID] = { updatedThreadStoreInfos[node.threadID] = {
...threadInfo, ...threadInfo,
members: updatedMembers, members: updatedMembers,
}; };
memberToThreadPermissionsForChildren = test; memberToThreadPermissionsForChildren =
updatedMemberToThreadPermissionsForChildren;
} }
node.children?.map(child => node.children?.map(child =>
recursivelyUpdatePermissions(child, memberToThreadPermissionsForChildren), recursivelyUpdatePermissions(child, memberToThreadPermissionsForChildren),
); );
}; };
const recursivelyUpdateCurrentMemberPermissions = ( const recursivelyUpdateCurrentMemberPermissions = (
▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines
View Options

native/themes/theme-handler.react.js

Loading...