Paths

Table of Contentst

Differential D9528

[lib/native] lift theme types from native into lib
ClosedPublic
Actions

Authored by ginsu on Oct 18 2023, 9:02 PM.

Tags

None

Referenced Files

	F3347894: D9528.diff
	Fri, Nov 22, 1:28 PM

	Unknown Object (File)
	Thu, Nov 14, 2:22 PM

	Unknown Object (File)
	Mon, Nov 11, 10:05 PM

	Unknown Object (File)
	Wed, Oct 30, 5:04 AM

	Unknown Object (File)
	Mon, Oct 28, 5:25 PM

	Unknown Object (File)
	Mon, Oct 28, 2:38 PM

	Unknown Object (File)
	Oct 4 2024, 1:46 AM

	Unknown Object (File)
	Oct 4 2024, 1:46 AM

View All 56 Files

Subscribers

Details

Reviewers

atul
rohan
inka

Commits

rCOMMb90afae0400d: [lib/native] lift theme types from native into lib

Summary

Now that we want to bring updateThemeInfo redux actions/state into web as well there are several things we should lift from native into lib so that we can share them across both platforms. This diff handles lifting the releveant theme types into lib

Part of https://linear.app/comm/issue/ENG-4956/lift-any-necessary-shared-types-selectors-functions-for-storing-the

Test Plan

flow and confirmed that updating the app theme on native still works as expected

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Oct 18 2023, 9:02 PM

Herald added subscribers: will, • ted, tomek, ashoat. · View Herald TranscriptOct 18 2023, 9:02 PM

ginsu added inline comments.Oct 18 2023, 9:07 PM

native/chat/settings/delete-thread.react.js
66 ↗	(On Diff #32172)	We weren't using `activeTheme` anywhere in this component, so I just removed it
native/profile/edit-password.react.js
46 ↗	(On Diff #32172)	We weren't using `activeTheme` anywhere in this component, so I just removed it

ginsu added reviewers: atul, rohan, inka.Oct 18 2023, 9:07 PM

ginsu edited the summary of this revision. (Show Details)Oct 18 2023, 9:11 PM

ginsu added a child revision: D9529: [native] rename native themes-types to theme-utils.

Harbormaster completed remote builds in B23343: Diff 32172.Oct 18 2023, 9:20 PM

ginsu requested review of this revision.Oct 18 2023, 9:20 PM

Seems reasonable

This revision is now accepted and ready to land.Oct 19 2023, 11:17 AM

rebase before landing

Harbormaster completed remote builds in B23389: Diff 32236.Oct 19 2023, 3:30 PM

Closed by commit rCOMMb90afae0400d: [lib/native] lift theme types from native into lib (authored by ginsu). · Explain WhyOct 19 2023, 5:55 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMb90afae0400d: [lib/native] lift theme types from native into lib.

Revision Contents
Changeset List

Path

Size

	lib/	types/
	native/	types/

	theme-types.js
	themes.js

6 lines

native/

chat/

settings/

delete-thread.react.js

4 lines

markdown/

3 lines

navigation/

nav-selectors.js

2 lines

profile/

appearance-preferences.react.js

10 lines

edit-password.react.js

4 lines

push/

in-app-notif.react.js

3 lines

push-handler.react.js

2 lines

redux/

action-types.js

2 lines

default-state.js

2 lines

2 lines

2 lines

theme-reducer.js

8 lines

themes/

3 lines

theme-handler.react.js

7 lines

types/

18 lines

utils/

6 lines

Diff 32236

lib/types/theme-types.js

Loading...

native/chat/settings/delete-thread.react.js

Loading...

native/markdown/styles.js

Loading...

native/navigation/nav-selectors.js

Loading...

native/profile/appearance-preferences.react.js

Loading...

native/profile/edit-password.react.js

Loading...

native/push/in-app-notif.react.js

Loading...

native/push/push-handler.react.js

Loading...

native/redux/action-types.js

Loading...

native/redux/default-state.js

Loading...

native/redux/persist.js

Loading...

native/redux/state-types.js

Loading...

native/redux/theme-reducer.js

Loading...

native/themes/colors.js

Loading...

native/themes/theme-handler.react.js

Loading...

native/types/themes.js

Loading...

native/utils/alert.js

Loading...