Page MenuHomePhabricator
Differential D9529

[native] rename native themes-types to theme-utils
ClosedPublic
Actions

Authored by ginsu on Oct 18 2023, 9:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 4 2025, 8:50 AM
Unknown Object (File)
Feb 16 2025, 2:42 AM
Unknown Object (File)
Feb 16 2025, 2:42 AM
Unknown Object (File)
Feb 16 2025, 2:42 AM
Unknown Object (File)
Feb 16 2025, 2:41 AM
Unknown Object (File)
Feb 16 2025, 2:36 AM
Unknown Object (File)
Jan 13 2025, 5:49 PM
Unknown Object (File)
Dec 31 2024, 7:08 PM
View All 66 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
rohan
Commits
rCOMM77d262dbe0cc: [native] rename native themes-types to theme-utils
Summary

Now that we lifted all the theme types into lib, the native file types would be better named as a utils file

Part of https://linear.app/comm/issue/ENG-4956/lift-any-necessary-shared-types-selectors-functions-for-storing-the

Depends on D9528

Test Plan

flow and confirmed that updating the app theme on native still works as expected

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
profile/
2 lines
themes/
2 lines
themes/
types/
7 lines
types/

Diff 32237

View Options

native/profile/appearance-preferences.react.js

Show All 20 Linesimport {
ModalProvider, ModalProvider,
useModalContext, useModalContext,
} from 'lib/components/modal-provider.react.js'; } from 'lib/components/modal-provider.react.js';
import { import {
createLoadingStatusSelector, createLoadingStatusSelector,
combineLoadingStatuses, combineLoadingStatuses,
} from 'lib/selectors/loading-selectors.js'; } from 'lib/selectors/loading-selectors.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js';
import type { Dispatch } from 'lib/types/redux-types.js'; import type { Dispatch } from 'lib/types/redux-types.js';
import { registerConfig } from 'lib/utils/config.js'; import { registerConfig } from 'lib/utils/config.js';
import { infoFromURL } from 'lib/utils/url-utils.js'; import { infoFromURL } from 'lib/utils/url-utils.js';
import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js'; import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js';
import QrCodeLogin from './account/qr-code-login.react.js'; import QrCodeLogin from './account/qr-code-login.react.js';
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 LinesregisterConfig({
resolveInvalidatedCookie: null, resolveInvalidatedCookie: null,
setSessionIDOnRequest: true, setSessionIDOnRequest: true,
// Never reset the calendar range // Never reset the calendar range
calendarRangeInactivityLimit: null, calendarRangeInactivityLimit: null,
platformDetails: { platformDetails: {
platform: electron?.platform ?? 'web', platform: electron?.platform ?? 'web',
codeVersion: 42, codeVersion: 42,
stateVersion: persistConfig.version, stateVersion: persistConfig.version,
majorDesktopVersion: electron?.version
? extractMajorDesktopVersion(electron?.version)
: null,
michalUnsubmitted
Not Done
Inline Actions

Related to my other comment, but I think it would be better to just not pass anything on web instead of null. majorDesktopVersion doesn't apply to the web in the same way as it doesn't apply to native.

michal: Related to my other comment, but I think it would be better to just not pass anything on web…
}, },
}); });
type BaseProps = { type BaseProps = {
+location: { +location: {
+pathname: string, +pathname: string,
... ...
}, },
▲ Show 20 Lines • Show All 297 Lines • Show Last 20 Lines
View Options

native/themes/theme-handler.react.js

Show All 20 Linesimport {
ModalProvider, ModalProvider,
useModalContext, useModalContext,
} from 'lib/components/modal-provider.react.js'; } from 'lib/components/modal-provider.react.js';
import { import {
createLoadingStatusSelector, createLoadingStatusSelector,
combineLoadingStatuses, combineLoadingStatuses,
} from 'lib/selectors/loading-selectors.js'; } from 'lib/selectors/loading-selectors.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js';
import type { Dispatch } from 'lib/types/redux-types.js'; import type { Dispatch } from 'lib/types/redux-types.js';
import { registerConfig } from 'lib/utils/config.js'; import { registerConfig } from 'lib/utils/config.js';
import { infoFromURL } from 'lib/utils/url-utils.js'; import { infoFromURL } from 'lib/utils/url-utils.js';
import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js'; import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js';
import QrCodeLogin from './account/qr-code-login.react.js'; import QrCodeLogin from './account/qr-code-login.react.js';
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 LinesregisterConfig({
resolveInvalidatedCookie: null, resolveInvalidatedCookie: null,
setSessionIDOnRequest: true, setSessionIDOnRequest: true,
// Never reset the calendar range // Never reset the calendar range
calendarRangeInactivityLimit: null, calendarRangeInactivityLimit: null,
platformDetails: { platformDetails: {
platform: electron?.platform ?? 'web', platform: electron?.platform ?? 'web',
codeVersion: 42, codeVersion: 42,
stateVersion: persistConfig.version, stateVersion: persistConfig.version,
majorDesktopVersion: electron?.version
? extractMajorDesktopVersion(electron?.version)
: null,
michalUnsubmitted
Not Done
Inline Actions

Related to my other comment, but I think it would be better to just not pass anything on web instead of null. majorDesktopVersion doesn't apply to the web in the same way as it doesn't apply to native.

michal: Related to my other comment, but I think it would be better to just not pass anything on web…
}, },
}); });
type BaseProps = { type BaseProps = {
+location: { +location: {
+pathname: string, +pathname: string,
... ...
}, },
▲ Show 20 Lines • Show All 297 Lines • Show Last 20 Lines
View Options

native/themes/theme-utils.js

Show All 20 Linesimport {
ModalProvider, ModalProvider,
useModalContext, useModalContext,
} from 'lib/components/modal-provider.react.js'; } from 'lib/components/modal-provider.react.js';
import { import {
createLoadingStatusSelector, createLoadingStatusSelector,
combineLoadingStatuses, combineLoadingStatuses,
} from 'lib/selectors/loading-selectors.js'; } from 'lib/selectors/loading-selectors.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js';
import type { Dispatch } from 'lib/types/redux-types.js'; import type { Dispatch } from 'lib/types/redux-types.js';
import { registerConfig } from 'lib/utils/config.js'; import { registerConfig } from 'lib/utils/config.js';
import { infoFromURL } from 'lib/utils/url-utils.js'; import { infoFromURL } from 'lib/utils/url-utils.js';
import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js'; import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js';
import QrCodeLogin from './account/qr-code-login.react.js'; import QrCodeLogin from './account/qr-code-login.react.js';
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 LinesregisterConfig({
resolveInvalidatedCookie: null, resolveInvalidatedCookie: null,
setSessionIDOnRequest: true, setSessionIDOnRequest: true,
// Never reset the calendar range // Never reset the calendar range
calendarRangeInactivityLimit: null, calendarRangeInactivityLimit: null,
platformDetails: { platformDetails: {
platform: electron?.platform ?? 'web', platform: electron?.platform ?? 'web',
codeVersion: 42, codeVersion: 42,
stateVersion: persistConfig.version, stateVersion: persistConfig.version,
majorDesktopVersion: electron?.version
? extractMajorDesktopVersion(electron?.version)
: null,
michalUnsubmitted
Not Done
Inline Actions

Related to my other comment, but I think it would be better to just not pass anything on web instead of null. majorDesktopVersion doesn't apply to the web in the same way as it doesn't apply to native.

michal: Related to my other comment, but I think it would be better to just not pass anything on web…
}, },
}); });
type BaseProps = { type BaseProps = {
+location: { +location: {
+pathname: string, +pathname: string,
... ...
}, },
▲ Show 20 Lines • Show All 297 Lines • Show Last 20 Lines
View Options

native/types/themes.js

Show All 20 Linesimport {
ModalProvider, ModalProvider,
useModalContext, useModalContext,
} from 'lib/components/modal-provider.react.js'; } from 'lib/components/modal-provider.react.js';
import { import {
createLoadingStatusSelector, createLoadingStatusSelector,
combineLoadingStatuses, combineLoadingStatuses,
} from 'lib/selectors/loading-selectors.js'; } from 'lib/selectors/loading-selectors.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js';
import type { Dispatch } from 'lib/types/redux-types.js'; import type { Dispatch } from 'lib/types/redux-types.js';
import { registerConfig } from 'lib/utils/config.js'; import { registerConfig } from 'lib/utils/config.js';
import { infoFromURL } from 'lib/utils/url-utils.js'; import { infoFromURL } from 'lib/utils/url-utils.js';
import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js'; import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js';
import QrCodeLogin from './account/qr-code-login.react.js'; import QrCodeLogin from './account/qr-code-login.react.js';
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 LinesregisterConfig({
resolveInvalidatedCookie: null, resolveInvalidatedCookie: null,
setSessionIDOnRequest: true, setSessionIDOnRequest: true,
// Never reset the calendar range // Never reset the calendar range
calendarRangeInactivityLimit: null, calendarRangeInactivityLimit: null,
platformDetails: { platformDetails: {
platform: electron?.platform ?? 'web', platform: electron?.platform ?? 'web',
codeVersion: 42, codeVersion: 42,
stateVersion: persistConfig.version, stateVersion: persistConfig.version,
majorDesktopVersion: electron?.version
? extractMajorDesktopVersion(electron?.version)
: null,
michalUnsubmitted
Not Done
Inline Actions

Related to my other comment, but I think it would be better to just not pass anything on web instead of null. majorDesktopVersion doesn't apply to the web in the same way as it doesn't apply to native.

michal: Related to my other comment, but I think it would be better to just not pass anything on web…
}, },
}); });
type BaseProps = { type BaseProps = {
+location: { +location: {
+pathname: string, +pathname: string,
... ...
}, },
▲ Show 20 Lines • Show All 297 Lines • Show Last 20 Lines