Page MenuHomePhabricator
Differential D9556

[native] remove device ID getter and setter functions
ClosedPublic
Actions

Authored by varun on Oct 20 2023, 9:40 AM.
Tags
None
Referenced Files
F3192637: D9556.id32436.diff
Fri, Nov 8, 10:04 PM
F3192636: D9556.id32284.diff
Fri, Nov 8, 10:04 PM
F3192514: D9556.id.diff
Fri, Nov 8, 10:01 PM
Unknown Object (File)
Tue, Nov 5, 2:13 AM
Unknown Object (File)
Tue, Oct 29, 2:52 PM
Unknown Object (File)
Oct 2 2024, 1:59 PM
Unknown Object (File)
Sep 19 2024, 10:47 AM
Unknown Object (File)
Sep 19 2024, 10:45 AM
View All 46 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
inka
kamil
marcin
Commits
rCOMM193f73f4bc28: [native] remove device ID getter and setter functions
Summary

a device's ID is their content ed25519 signing public key. this gets created when the content olm account is created in the CryptoModule.

it seems like we can safely deprecate getDeviceID and setDeviceID and remove the callsite in sqlite-data-handler.js

Test Plan

successfully ran the app. tried logging in and out, registering and deleting an account. everything worked fine.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Oct 20 2023, 9:40 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 20 2023, 9:40 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 20 2023, 9:43 AM
Harbormaster failed remote builds in B23408: Diff 32284!
varun updated this revision to Diff 32287.Oct 20 2023, 10:25 AM

apparently we use native/cpp files on web? @kamil can you please make sure this update is correct? i ran yarn build-db-wasm

Harbormaster completed remote builds in B23410: Diff 32287.Oct 20 2023, 10:45 AM
varun requested review of this revision.Oct 20 2023, 10:45 AM
kamil accepted this revision.Oct 23 2023, 12:49 AM
In D9556#280174, @varun wrote:

apparently we use native/cpp files on web?

Yes, those are WASM bindings and the files are web-specific.

@kamil can you please make sure this update is correct? i ran yarn build-db-wasm

Running yarn build-db-wasm and committing generated files is everything that needs to be done, looks okay.

Do we have to keep rust and web code, or also can be removed?

marcin accepted this revision.Oct 24 2023, 3:16 AM
inka accepted this revision.Oct 25 2023, 3:31 AM
This revision is now accepted and ready to land.Oct 25 2023, 3:31 AM
varun added a child revision: D9612: [native][web] remove unused device ID code.Oct 26 2023, 10:26 AM
varun added a comment.Oct 26 2023, 10:27 AM

Do we have to keep rust and web code, or also can be removed?

addressed in follow up diff

Closed by commit rCOMM193f73f4bc28: [native] remove device ID getter and setter functions (authored by varun). · Explain WhyOct 26 2023, 10:28 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM193f73f4bc28: [native] remove device ID getter and setter functions.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
CryptoTools/
DatabaseManagers/
2 lines
2 lines
8 lines
NativeModules/
3 lines
67 lines
_generated/
data/
4 lines
ios/
Comm.xcodeproj/
2 lines
schema/
2 lines
web/
database/
_generated/

Diff 32436

View Options

native/cpp/CommonCpp/CryptoTools/DeviceID.h

Loading...
View Options

native/cpp/CommonCpp/CryptoTools/DeviceID.cpp

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/data/sqlite-data-handler.js

Loading...
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...
View Options

web/database/_generated/comm_query_executor.wasm

Loading...