[lib] introduce selected keyservers selector
ClosedPublic
Actions

Authored by ginsu on Oct 31 2023, 1:00 AM.

Details

Reviewers

inka
michal
rohan

Commits

rCOMM6dfc1c43efbd: [lib] introduce selected keyservers selector

Summary

In order to populate the list of selected keyservers the user has added, we need to introduce this selector which selects all the keyserver infos in the keyserver store and additionally appends the keyserver admin username

Linear task: https://linear.app/comm/issue/ENG-5370/introduce-connected-keyservers-selector

Depends on D9639

Test Plan

Logged out the result of the selector and got the following (the second keyserver is just a test "dummy" keyserver I added to the keyserver store when testing the add keyserver flow)

Screenshot 2023-10-31 at 4.03.18 AM.png (1×1 px, 170 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Oct 31 2023, 1:00 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 31 2023, 1:00 AM

ginsu edited the test plan for this revision. (Show Details)Oct 31 2023, 1:04 AM

ginsu added reviewers: inka, michal, rohan.

ginsu attached a referenced file: F843721: Screenshot 2023-10-31 at 4.03.18 AM.png. (Show Details)

ginsu edited the summary of this revision. (Show Details)

ginsu edited the test plan for this revision. (Show Details)

ginsu added a parent revision: D9639: [lib] introduce KeyserverInfos type.

ginsu edited the test plan for this revision. (Show Details)Oct 31 2023, 1:07 AM

ginsu added a child revision: D9642: [native] implement keyserver list ui.Oct 31 2023, 1:19 AM

Harbormaster completed remote builds in B23583: Diff 32518.Oct 31 2023, 1:46 AM

ginsu requested review of this revision.Oct 31 2023, 1:46 AM

Seems reasonable

lib/selectors/keyserver-selectors.js
69–71	When do we expect this to be undefined?
lib/types/keyserver-types.js
30	Doesn't matter but I think this is a singular `SelectedKeyserverInfo`

This revision is now accepted and ready to land.Oct 31 2023, 6:47 AM

ginsu added inline comments.Oct 31 2023, 12:04 PM

lib/selectors/keyserver-selectors.js
69–71	We really should always have this, but the `username` in `UserInfo` is optional https://github.com/CommE2E/comm/blob/master/lib/types/user-types.js#L34-L39 In the `CommunityPill` component we also do something similar where if the keyserver admin username is not defined we return `undefined`, and that is where I got my idea for this implementation https://github.com/CommE2E/comm/blob/master/native/components/community-pill.react.js#L27-L29