Page MenuHomePhabricator
Differential D9818

Refactor Windows push code to match conventions for other platforms
ClosedPublic
Actions

Authored by marcin on Nov 10 2023, 5:43 AM.
Tags
None
Referenced Files
F3389184: D9818.diff
Fri, Nov 29, 5:54 PM
F3388063: D9818.id33064.diff
Fri, Nov 29, 12:33 PM
Unknown Object (File)
Wed, Nov 27, 8:51 AM
Unknown Object (File)
Oct 27 2024, 8:54 PM
Unknown Object (File)
Oct 4 2024, 4:20 AM
Unknown Object (File)
Sep 29 2024, 12:52 AM
Unknown Object (File)
Sep 29 2024, 12:52 AM
Unknown Object (File)
Sep 29 2024, 12:52 AM
View All 97 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
michal
Commits
rCOMM694db6d6559a: Refactor Windows push code to match conventions for other platforms
Summary

This differential does not introduce new functionality but unifies typing and signature for push-related functions for all platforms.

Test Plan

Ensure that Windows notifications work correctly.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Nov 10 2023, 5:43 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 10 2023, 5:43 AM
Harbormaster completed remote builds in B23990: Diff 33064.Nov 10 2023, 6:03 AM
marcin requested review of this revision.Nov 10 2023, 6:03 AM
marcin updated this revision to Diff 33067.Nov 10 2023, 6:08 AM

Rebase to update commit message

marcin added a parent revision: D9817: Add encryption order to encrypted notifications.Nov 10 2023, 6:09 AM
marcin added a child revision: D9819: Send visual notifications in the same order as they were encrypted.
Harbormaster completed remote builds in B23993: Diff 33067.Nov 10 2023, 6:50 AM
michal accepted this revision.Nov 14 2023, 7:21 AM
This revision is now accepted and ready to land.Nov 14 2023, 7:21 AM
marcin updated this revision to Diff 33545.Nov 23 2023, 2:07 AM

Rebase before landing

Harbormaster completed remote builds in B24365: Diff 33545.Nov 23 2023, 4:15 AM
Closed by commit rCOMM694db6d6559a: Refactor Windows push code to match conventions for other platforms (authored by marcin). · Explain WhyNov 23 2023, 5:50 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM694db6d6559a: Refactor Windows push code to match conventions for other platforms.

Revision Contents
Changeset List

PathSize
keyserver/
src/
push/
20 lines
11 lines
27 lines

Diff 33064

View Options

keyserver/src/push/send.js

Loading...
View Options

keyserver/src/push/types.js

Loading...
View Options

keyserver/src/push/utils.js

Loading...