Paths

Table of Contentst

Differential D9826

[lib/native] extend keyserverAdminUsername to be keyserverAdminUserInfo
ClosedPublic
Actions

Authored by ginsu on Nov 10 2023, 11:15 AM.

Tags

None

Referenced Files

	F3246973: D9826.id33076.diff
	Fri, Nov 15, 2:45 AM

	F3246954: D9826.id33238.diff
	Fri, Nov 15, 2:38 AM

	F3246570: D9826.diff
	Fri, Nov 15, 12:41 AM

	Unknown Object (File)
	Fri, Nov 8, 4:11 AM

	Unknown Object (File)
	Wed, Nov 6, 1:43 PM

	Unknown Object (File)
	Sun, Oct 27, 11:43 PM

	Unknown Object (File)
	Oct 16 2024, 12:32 AM

	Unknown Object (File)
	Sep 28 2024, 2:50 AM

View All 62 Files

Subscribers

Details

Reviewers

inka
rohan
michal

Commits

rCOMM371f6f808e5e: [lib/native] extend keyserverAdminUsername to be keyserverAdminUserInfo

Summary

The remove keyserver action needs the keyserver admin user id. I realized as I was implementing the solution to remove a keyserver from the keyserver store that I am only had the username available to me. This diff extends the keyserverAdminUsername to be keyserverAdminUserInfo which also holds the keyserver admin user id

Depends on D9806

Test Plan

flow and confirmed that I now have the userID in the keyserverAdminUserInfo

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Nov 10 2023, 11:15 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 10 2023, 11:15 AM

update

ginsu edited the summary of this revision. (Show Details)Nov 10 2023, 11:19 AM

ginsu added reviewers: inka, rohan, michal.

ginsu added a parent revision: D9806: [lib] introduce removeKeyserverActionType.

ginsu added a child revision: D9828: [native] introduce temp onPressDisconnectKeyserver callback.Nov 10 2023, 11:31 AM

Harbormaster completed remote builds in B24003: Diff 33077.Nov 10 2023, 11:47 AM

ginsu requested review of this revision.Nov 10 2023, 11:47 AM

Harbormaster completed remote builds in B24002: Diff 33076.Nov 10 2023, 11:50 AM

inka accepted this revision.Nov 14 2023, 12:26 AM

This revision is now accepted and ready to land.Nov 14 2023, 12:26 AM

rebase before landing

This revision was landed with ongoing or failed builds.Nov 14 2023, 5:47 PM

Closed by commit rCOMM371f6f808e5e: [lib/native] extend keyserverAdminUsername to be keyserverAdminUserInfo (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM371f6f808e5e: [lib/native] extend keyserverAdminUsername to be keyserverAdminUserInfo.

Harbormaster failed remote builds in B24131: Diff 33238!Nov 14 2023, 5:57 PM

Harbormaster completed remote builds in B24131: Diff 33238.Nov 14 2023, 6:51 PM

Revision Contents
Changeset List

Path

Size

lib/

selectors/

keyserver-selectors.js

11 lines

types/

keyserver-types.js

3 lines

native/

profile/

keyserver-selection-bottom-sheet.react.js

7 lines

keyserver-selection-list-item.react.js

13 lines

keyserver-selection-list.react.js

2 lines

Diff 33076

lib/selectors/keyserver-selectors.js

Loading...

lib/types/keyserver-types.js

Loading...

native/profile/keyserver-selection-bottom-sheet.react.js

Loading...

native/profile/keyserver-selection-list-item.react.js

Loading...

native/profile/keyserver-selection-list.react.js

Loading...