[identity] Extract insert_into_cache to trait
ClosedPublic
Actions

Authored by bartek on Nov 20 2023, 12:17 PM.

Details

Reviewers

varun
michal

Commits

rCOMM97cfab9e31ed: [identity] Extract insert_into_cache to trait

Summary

I'll need the insert_into_cache() function in authenticated proto too, so I thought it'd be nice to make it more universal as an extension to the Cache.

Depends on D9928.

Test Plan

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Nov 20 2023, 12:17 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 20 2023, 12:17 PM

bartek added a child revision: D9930: [identity] Move UpdateUserPassword RPCs.Nov 20 2023, 12:20 PM

bartek published this revision for review.Nov 20 2023, 12:50 PM

Harbormaster failed remote builds in B24269: Diff 33407!Nov 20 2023, 1:11 PM

varun accepted this revision.Nov 20 2023, 7:32 PM

This revision is now accepted and ready to land.Nov 20 2023, 7:32 PM

This revision was landed with ongoing or failed builds.Dec 4 2023, 10:43 AM

Closed by commit rCOMM97cfab9e31ed: [identity] Extract insert_into_cache to trait. · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM97cfab9e31ed: [identity] Extract insert_into_cache to trait.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

client_service.rs

27 lines

Diff 33407

View Options

services/identity/src/client_service.rs

[identity] Extract insert_into_cache to traitClosedPublicActions