Page MenuHomePhabricator
Differential D10050

[identity] Delete unauthenticated X3DH RPCs
ClosedPublic
Actions

Authored by bartek on Nov 27 2023, 4:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 23, 9:06 AM
Unknown Object (File)
Thu, Apr 17, 1:17 PM
Unknown Object (File)
Thu, Apr 17, 12:01 PM
Unknown Object (File)
Thu, Apr 17, 6:17 AM
Unknown Object (File)
Thu, Apr 17, 12:31 AM
Unknown Object (File)
Wed, Apr 16, 2:24 AM
Unknown Object (File)
Wed, Apr 9, 12:12 PM
Unknown Object (File)
Mar 26 2025, 7:15 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
Commits
rCOMM3ab77926b70e: [identity] Delete unauthenticated X3DH RPCs
Summary

We can now delete the unauthenticated X3DH RPCs.

Depends on D10049

Test Plan

Identity client compiles

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
services/
identity/
src/
108 lines
15 lines
shared/
protos/
33 lines

Diff 33722

View Options

services/identity/src/client_service.rs

Show First 20 Lines • Show All 69 Lines • ▼ Show 20 Lines if (!isViewer && startsCluster) {
height += authorNameHeight; height += authorNameHeight;
} }
if (endsCluster) { if (endsCluster) {
height += clusterEndHeight; height += clusterEndHeight;
} }
if (textMessageSendFailed(item)) { if (textMessageSendFailed(item)) {
height += failedSendHeight; height += failedSendHeight;
} }
const label = getMessageLabel(item.hasBeenEdited, threadInfo); const label = getMessageLabel(item.hasBeenEdited, threadInfo.id);
if (item.threadCreatedFromMessage || Object.keys(item.reactions).length > 0) { if (item.threadCreatedFromMessage || Object.keys(item.reactions).length > 0) {
height += height +=
inlineEngagementStyle.height + inlineEngagementStyle.height +
inlineEngagementStyle.marginTop + inlineEngagementStyle.marginTop +
inlineEngagementStyle.marginBottom; inlineEngagementStyle.marginBottom;
} else if (label) { } else if (label) {
height += height +=
inlineEngagementLabelStyle.height + inlineEngagementLabelStyle.height +
▲ Show 20 Lines • Show All 367 Lines • Show Last 20 Lines
View Options

services/identity/src/database.rs

Show First 20 Lines • Show All 69 Lines • ▼ Show 20 Lines if (!isViewer && startsCluster) {
height += authorNameHeight; height += authorNameHeight;
} }
if (endsCluster) { if (endsCluster) {
height += clusterEndHeight; height += clusterEndHeight;
} }
if (textMessageSendFailed(item)) { if (textMessageSendFailed(item)) {
height += failedSendHeight; height += failedSendHeight;
} }
const label = getMessageLabel(item.hasBeenEdited, threadInfo); const label = getMessageLabel(item.hasBeenEdited, threadInfo.id);
if (item.threadCreatedFromMessage || Object.keys(item.reactions).length > 0) { if (item.threadCreatedFromMessage || Object.keys(item.reactions).length > 0) {
height += height +=
inlineEngagementStyle.height + inlineEngagementStyle.height +
inlineEngagementStyle.marginTop + inlineEngagementStyle.marginTop +
inlineEngagementStyle.marginBottom; inlineEngagementStyle.marginBottom;
} else if (label) { } else if (label) {
height += height +=
inlineEngagementLabelStyle.height + inlineEngagementLabelStyle.height +
▲ Show 20 Lines • Show All 367 Lines • Show Last 20 Lines
View Options

shared/protos/identity_client.proto

Show First 20 Lines • Show All 69 Lines • ▼ Show 20 Lines if (!isViewer && startsCluster) {
height += authorNameHeight; height += authorNameHeight;
} }
if (endsCluster) { if (endsCluster) {
height += clusterEndHeight; height += clusterEndHeight;
} }
if (textMessageSendFailed(item)) { if (textMessageSendFailed(item)) {
height += failedSendHeight; height += failedSendHeight;
} }
const label = getMessageLabel(item.hasBeenEdited, threadInfo); const label = getMessageLabel(item.hasBeenEdited, threadInfo.id);
if (item.threadCreatedFromMessage || Object.keys(item.reactions).length > 0) { if (item.threadCreatedFromMessage || Object.keys(item.reactions).length > 0) {
height += height +=
inlineEngagementStyle.height + inlineEngagementStyle.height +
inlineEngagementStyle.marginTop + inlineEngagementStyle.marginTop +
inlineEngagementStyle.marginBottom; inlineEngagementStyle.marginBottom;
} else if (label) { } else if (label) {
height += height +=
inlineEngagementLabelStyle.height + inlineEngagementLabelStyle.height +
▲ Show 20 Lines • Show All 367 Lines • Show Last 20 Lines