Details

Reviewers

inka
michal
rohan

Commits

rCOMM01beb1a4d4ac: [web] introduce add keyserver modal

Summary

This diff introduces the add keyserver modal. The focus of this diff is just the interface, and subsquent diffs will handle implementing the behavoir of adding a keyserver to the keyserver store

for context here is the figma design:

Screenshot 2023-11-16 at 1.02.31 PM.png (1×1 px, 172 KB)

linear task: https://linear.app/comm/issue/ENG-5496/introduce-add-keyserver-input-ui

Depends on D9892

Test Plan

Please see screenshot below

Screenshot 2023-11-16 at 12.56.49 PM.png (1×3 px, 718 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Nov 16 2023, 9:58 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 16 2023, 9:58 AM

update

ginsu edited the summary of this revision. (Show Details)Nov 16 2023, 10:03 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: inka, michal, rohan.

ginsu added a parent revision: D9892: [web] introduce keyserver selection list.

ginsu attached a referenced file: F881672: Screenshot 2023-11-16 at 12.56.49 PM.png. (Show Details)

ginsu attached a referenced file: F881673: Screenshot 2023-11-16 at 1.02.31 PM.png. (Show Details)

ginsu edited the summary of this revision. (Show Details)Nov 16 2023, 10:05 AM

ginsu published this revision for review.Nov 16 2023, 10:22 AM

Harbormaster failed remote builds in B24214: Diff 33347!Nov 16 2023, 10:30 AM

Harbormaster failed remote builds in B24216: Diff 33349!Nov 16 2023, 10:53 AM

ginsu added a child revision: D9918: [web] introduce add keyserver button.Nov 16 2023, 12:22 PM

Another design question - just in terms of consistency, do normally use a darker background behind the action button in modals? My experience with modals is they're the same color throughout, and the button doesn't have a darker background behind it

web/modals/keyserver-selection/add-keyserver-modal.css
11 ↗	(On Diff #33349)	Would it make more sense to use a modal color here as opposed to a panel? Not sure

address comments

Another design question - just in terms of consistency, do normally use a darker background behind the action button in modals?

Spoke to @rohan about this during dec planning sync, and showed him that this new design is part of the new web UI. Since this interface is only available to devs/staff I figured it would be good to start that introduction. Part of my December work will be to unify the look of all the modals to this.

Harbormaster completed remote builds in B24581: Diff 33957.Nov 28 2023, 1:04 PM

Accepting since the code looks good (and colors look consistent)!

I'm not so sure about the specific color variables but I assume you've signed off on them / agreed on them prior

This revision is now accepted and ready to land.Nov 28 2023, 4:20 PM

rohan added inline comments.Nov 28 2023, 4:21 PM