Page MenuHomePhabricator
Differential D9918

[web] introduce add keyserver button
ClosedPublic
Actions

Authored by ginsu on Nov 16 2023, 12:16 PM.
Tags
None
Referenced Files
F3180250: D9918.id33960.diff
Fri, Nov 8, 4:29 AM
Unknown Object (File)
Tue, Nov 5, 2:13 AM
Unknown Object (File)
Thu, Oct 24, 8:56 AM
Unknown Object (File)
Sep 27 2024, 1:01 PM
Unknown Object (File)
Sep 11 2024, 2:44 PM
Unknown Object (File)
Sep 11 2024, 2:44 PM
Unknown Object (File)
Sep 11 2024, 2:44 PM
Unknown Object (File)
Sep 11 2024, 2:43 PM
View All 90 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
michal
rohan
Commits
rCOMM63b03a1c242c: [web] introduce add keyserver button
Summary

This diff introduces the add keyserver button element on to the keyserver selection list screen. When a user clicks on this element we should push the add keyserver modal

Here is a screenshot of the figma for context:

Screenshot 2023-11-14 at 5.21.32 PM.png (1×1 px, 170 KB)

Linear task: https://linear.app/comm/issue/ENG-4724/create-add-keyserver-button-element

Depends on D9916

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Nov 16 2023, 12:16 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 16 2023, 12:16 PM
ginsu mentioned this in D9892: [web] introduce keyserver selection list.Nov 16 2023, 12:20 PM
ginsu edited the summary of this revision. (Show Details)Nov 16 2023, 12:22 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: inka, michal, rohan.
ginsu added a parent revision: D9916: [web] introduce add keyserver modal.
ginsu attached a referenced file: F882157: Screen Recording 2023-11-16 at 3.21.23 PM.mov. (Show Details)
ginsu attached a referenced file: F882158: Screenshot 2023-11-14 at 5.21.32 PM.png. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 16 2023, 12:46 PM
Harbormaster failed remote builds in B24224: Diff 33360!
ginsu requested review of this revision.Nov 16 2023, 12:51 PM
ginsu added a child revision: D9920: [web] introduce keyserver selection modal.Nov 16 2023, 1:06 PM
rohan accepted this revision.Nov 17 2023, 7:55 AM

Code looks fine! I'm assuming the color additions to theme.css were all agreed on before hand

web/settings/keyserver-selection-list.react.js
35–37 ↗(On Diff #33360)
This revision is now accepted and ready to land.Nov 17 2023, 7:55 AM
ginsu updated this revision to Diff 33960.Nov 28 2023, 7:16 PM

address comments + rebase before landing

Harbormaster completed remote builds in B24584: Diff 33960.Nov 28 2023, 7:48 PM
Closed by commit rCOMM63b03a1c242c: [web] introduce add keyserver button (authored by ginsu). · Explain WhyNov 28 2023, 8:07 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM63b03a1c242c: [web] introduce add keyserver button.

Revision Contents
Changeset List

Diff 33963

View Options

web/settings/keyserver-selection-list.css

Loading...
View Options

web/settings/keyserver-selection-list.react.js

Loading...
View Options

web/theme.css

Loading...