Page MenuHomePhabricator
Differential D10127

[native] Replace `LegacyThreadInfo` with `ThreadInfo` where simple
ClosedPublic
Actions

Authored by atul on Nov 30 2023, 7:45 PM.
Tags
None
Referenced Files
F3366065: D10127.diff
Mon, Nov 25, 9:22 AM
Unknown Object (File)
Sat, Nov 23, 9:24 PM
Unknown Object (File)
Wed, Oct 30, 10:20 PM
Unknown Object (File)
Oct 12 2024, 8:59 AM
Unknown Object (File)
Oct 4 2024, 8:07 PM
Unknown Object (File)
Oct 2 2024, 1:35 AM
Unknown Object (File)
Oct 2 2024, 1:35 AM
Unknown Object (File)
Oct 2 2024, 1:35 AM
View All 62 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMM368c2390ab77: [native] Replace `LegacyThreadInfo` with `ThreadInfo` where simple
Summary

Similar to D10126, but for native.

Depends on D10126

Test Plan

CI/flow/etc

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Nov 30 2023, 7:45 PM
atul added a comment.Nov 30 2023, 7:45 PM

Down to 143 instances of LegacyThreadInfo..

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 30 2023, 7:56 PM
Harbormaster failed remote builds in B24673: Diff 34087!
atul updated this revision to Diff 34088.Nov 30 2023, 8:01 PM

fix import in push-handler

atul added a child revision: D10128: [web] Replace `LegacyThreadInfo` with `ThreadInfo` where simple.Nov 30 2023, 8:13 PM
Harbormaster completed remote builds in B24674: Diff 34088.Nov 30 2023, 8:21 PM
atul requested review of this revision.Nov 30 2023, 8:21 PM
rohan accepted this revision.Dec 1 2023, 6:17 AM

Looks good, just a question inline

native/push/push-handler.react.js
107

Are you not able to replace this one yet

This revision is now accepted and ready to land.Dec 1 2023, 6:17 AM
atul added inline comments.Dec 1 2023, 12:36 PM
native/push/push-handler.react.js
107

Ended up replacing this in the last diff of the stack. It might've been possible at this point?

Closed by commit rCOMM368c2390ab77: [native] Replace `LegacyThreadInfo` with `ThreadInfo` where simple (authored by atul). · Explain WhyDec 1 2023, 12:44 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM368c2390ab77: [native] Replace `LegacyThreadInfo` with `ThreadInfo` where simple.

Revision Contents
Changeset List

Diff 34088

View Options

native/calendar/entry.react.js

Loading...
View Options

native/chat/chat-input-bar.react.js

Loading...
View Options

native/chat/chat-router.js

Loading...
View Options

native/chat/chat-thread-list.react.js

Loading...
View Options

native/chat/compose-subchannel.react.js

Loading...
View Options

native/chat/failed-send.react.js

Loading...
View Options

native/chat/message-list-types.js

Loading...
View Options

native/chat/message-preview.react.js

Loading...
View Options

native/chat/settings/thread-settings.react.js

Loading...
View Options

native/chat/thread-list-modal.react.js

Loading...
View Options

native/chat/toggle-pin-modal.react.js

Loading...
View Options

native/components/thread-ancestors.react.js

Loading...
View Options

native/components/thread-list-thread.react.js

Loading...
View Options

native/components/thread-list.react.js

Loading...
View Options

native/push/push-handler.react.js

Loading...
View Options

native/user-profile/user-profile-message-button.react.js

Loading...