Paths

Table of Contentst

[lib] Replace `LegacyThreadInfo` with `ThreadInfo` in `lib/shared`
ClosedPublic
Actions

Authored by atul on Dec 1 2023, 8:15 AM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMM67914187ef09: [lib] Replace `LegacyThreadInfo` with `ThreadInfo` in `lib/shared`

Summary

Updated message-spec and then made necessary changes.

We're now at 94 instances of LegacyThreadInfo down from 700+...

Depends on D10136

Test Plan

CI/flow/etc.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

include more

atul published this revision for review.Dec 1 2023, 8:17 AM

atul edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B24694: Diff 34126.Dec 1 2023, 8:43 AM

atul added a child revision: D10138: [lib] Update `useRoleUserSurfacedPermissions` to handle `MinimallyEncodedThreadInfo`.Dec 1 2023, 8:45 AM

Harbormaster completed remote builds in B24695: Diff 34127.Dec 1 2023, 8:50 AM

ashoat accepted this revision.Dec 1 2023, 9:15 AM

This revision is now accepted and ready to land.Dec 1 2023, 9:15 AM

Closed by commit rCOMM67914187ef09: [lib] Replace `LegacyThreadInfo` with `ThreadInfo` in `lib/shared` (authored by atul). · Explain WhyDec 1 2023, 12:44 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM67914187ef09: [lib] Replace `LegacyThreadInfo` with `ThreadInfo` in `lib/shared`.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

add-members-message-spec.js

4 lines

change-role-message-spec.js

4 lines

change-settings-message-spec.js

4 lines

create-entry-message-spec.js

4 lines

create-sidebar-message-spec.js

4 lines

create-sub-thread-message-spec.js

4 lines

create-thread-message-spec.js

4 lines

delete-entry-message-spec.js

4 lines

edit-entry-message-spec.js

4 lines

join-thread-message-spec.js

4 lines

leave-thread-message-spec.js

4 lines

message-spec.js

20 lines

multimedia-message-spec.js

4 lines

reaction-message-spec.js

4 lines

remove-members-message-spec.js

4 lines

restore-entry-message-spec.js

4 lines

text-message-spec.js

9 lines

update-relationship-message-spec.js

4 lines

notif-utils.js

6 lines

Diff 34126

View Options

lib/shared/messages/add-members-message-spec.js

View Options

lib/shared/messages/change-role-message-spec.js

View Options

lib/shared/messages/change-settings-message-spec.js

View Options

lib/shared/messages/create-entry-message-spec.js

View Options

lib/shared/messages/create-sidebar-message-spec.js

View Options

lib/shared/messages/create-sub-thread-message-spec.js

View Options

lib/shared/messages/create-thread-message-spec.js

View Options

lib/shared/messages/delete-entry-message-spec.js

View Options

lib/shared/messages/edit-entry-message-spec.js

View Options

lib/shared/messages/join-thread-message-spec.js

View Options

lib/shared/messages/leave-thread-message-spec.js

View Options

lib/shared/messages/message-spec.js

View Options

lib/shared/messages/multimedia-message-spec.js

View Options

lib/shared/messages/reaction-message-spec.js

View Options

lib/shared/messages/remove-members-message-spec.js

View Options

lib/shared/messages/restore-entry-message-spec.js

View Options

lib/shared/messages/text-message-spec.js

View Options

lib/shared/messages/update-relationship-message-spec.js

View Options

[lib] Replace `LegacyThreadInfo` with `ThreadInfo` in `lib/shared`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 34126

lib/shared/messages/add-members-message-spec.js

lib/shared/messages/change-role-message-spec.js

lib/shared/messages/change-settings-message-spec.js

lib/shared/messages/create-entry-message-spec.js

lib/shared/messages/create-sidebar-message-spec.js

lib/shared/messages/create-sub-thread-message-spec.js

lib/shared/messages/create-thread-message-spec.js

lib/shared/messages/delete-entry-message-spec.js

lib/shared/messages/edit-entry-message-spec.js

lib/shared/messages/join-thread-message-spec.js

lib/shared/messages/leave-thread-message-spec.js

lib/shared/messages/message-spec.js

lib/shared/messages/multimedia-message-spec.js

lib/shared/messages/reaction-message-spec.js

lib/shared/messages/remove-members-message-spec.js

lib/shared/messages/restore-entry-message-spec.js

lib/shared/messages/text-message-spec.js

lib/shared/messages/update-relationship-message-spec.js

lib/shared/notif-utils.js

[lib] Replace `LegacyThreadInfo` with `ThreadInfo` in `lib/shared`
ClosedPublic
Actions

Revision Contents
Changeset List