Paths

Table of Contentst

Differential D10142

Rip `LegacyThreadInfo` out of selectors and related code
ClosedPublic
Actions

Authored by atul on Dec 1 2023, 11:24 AM.

Tags

None

Referenced Files

	F3385504: D10142.id34135.diff
	Fri, Nov 29, 12:44 AM

	F3385495: D10142.id34136.diff
	Fri, Nov 29, 12:40 AM

	Unknown Object (File)
	Thu, Nov 7, 4:20 AM

	Unknown Object (File)
	Wed, Oct 30, 6:50 PM

	Unknown Object (File)
	Oct 2 2024, 11:50 PM

	Unknown Object (File)
	Oct 2 2024, 12:30 AM

	Unknown Object (File)
	Oct 2 2024, 12:30 AM

	Unknown Object (File)
	Oct 2 2024, 12:30 AM

View All 75 Files

Subscribers

None

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMMaca9f25487d3: Rip `LegacyThreadInfo` out of selectors and related code

Summary

Ripped LegacyThreadInfo out of selectors and updated related code to use ThreadInfo as well.

We're now down to 6 usages of LegacyThreadInfo from ~750

WARNING: There was one instance where we had to add noop branching to web/modals/threads/settings/thread-settings-modal.react.js:68-72 to appease flow.

Depends on D10140

Test Plan

CI/flow/etc.

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Dec 1 2023, 11:24 AM

atul added inline comments.Dec 1 2023, 11:25 AM

web/chat/thread-list-provider.js
152	This was accidental, it will be removed.
web/modals/threads/settings/thread-settings-modal.react.js
68–72	NOTE: This is the one place we had to add branching to appease flow.

update

atul published this revision for review.Dec 1 2023, 11:28 AM

atul edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B24702: Diff 34135.Dec 1 2023, 11:52 AM

Harbormaster completed remote builds in B24703: Diff 34136.Dec 1 2023, 12:02 PM

ashoat accepted this revision.Dec 1 2023, 12:18 PM

This revision is now accepted and ready to land.Dec 1 2023, 12:18 PM

include more

atul edited the summary of this revision. (Show Details)Dec 1 2023, 12:21 PM

This revision was landed with ongoing or failed builds.Dec 1 2023, 12:44 PM

Closed by commit rCOMMaca9f25487d3: Rip `LegacyThreadInfo` out of selectors and related code (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMaca9f25487d3: Rip `LegacyThreadInfo` out of selectors and related code.

Harbormaster completed remote builds in B24710: Diff 34143.Dec 1 2023, 1:23 PM

Revision Contents
Changeset List

Path

Size

lib/

selectors/

chat-selectors.js

19 lines

thread-selectors.js

37 lines

shared/

ancestor-threads.js

7 lines

message-utils.js

8 lines

10 lines

thread-utils.js

6 lines

types/

thread-types.js

4 lines

utils/

entity-helpers.js

11 lines

native/

chat/

settings/

thread-settings.react.js

3 lines

push/

push-handler.react.js

4 lines

selectors/

calendar-selectors.js

6 lines

web/

chat/

thread-list-provider.js

5 lines

modals/

threads/

settings/

thread-settings-modal.react.js

13 lines

selectors/

chat-selectors.js

8 lines

Diff 34135

lib/selectors/chat-selectors.js

Loading...

lib/selectors/thread-selectors.js

Loading...

lib/shared/ancestor-threads.js

Loading...

lib/shared/message-utils.js

Loading...

lib/shared/notif-utils.js

Loading...

lib/shared/thread-utils.js

Loading...

lib/types/thread-types.js

Loading...

lib/utils/entity-helpers.js

Loading...

native/chat/settings/thread-settings.react.js

Loading...

native/push/push-handler.react.js

Loading...

native/selectors/calendar-selectors.js

Loading...

web/chat/thread-list-provider.js

Loading...

web/modals/threads/settings/thread-settings-modal.react.js

Loading...

web/selectors/chat-selectors.js

Loading...