Page MenuHomePhabricator
Differential D10140

[native] Rip `LegacyThreadInfo` out of `native/chat`
ClosedPublic
Actions

Authored by atul on Dec 1 2023, 9:10 AM.
Tags
None
Referenced Files
F3366083: D10140.id34158.diff
Mon, Nov 25, 9:28 AM
F3365778: D10140.diff
Mon, Nov 25, 7:41 AM
Unknown Object (File)
Sat, Nov 23, 11:16 PM
Unknown Object (File)
Sun, Nov 17, 2:11 AM
Unknown Object (File)
Wed, Oct 30, 6:50 PM
Unknown Object (File)
Mon, Oct 28, 3:00 AM
Unknown Object (File)
Oct 2 2024, 1:35 AM
Unknown Object (File)
Oct 2 2024, 1:35 AM
View All 49 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMMd1cddf319e6f: [native] Rip `LegacyThreadInfo` out of `native/chat`
Summary

Update all props and callbacks being "drilled" to ThreadInfo from LegacyThreadInfo.

We're now down to 61 usages of LegacyThreadInfo from 700+

Depends on D10139

Test Plan

CI/flow/etc.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Dec 1 2023, 9:10 AM
atul published this revision for review.Dec 1 2023, 9:12 AM
atul edited the summary of this revision. (Show Details)
ashoat accepted this revision.Dec 1 2023, 9:20 AM
This revision is now accepted and ready to land.Dec 1 2023, 9:20 AM
Harbormaster failed remote builds in B24699: Diff 34131!Dec 1 2023, 9:23 AM
atul added a child revision: D10142: Rip `LegacyThreadInfo` out of selectors and related code.Dec 1 2023, 11:24 AM
This revision was landed with ongoing or failed builds.Dec 1 2023, 12:44 PM
Closed by commit rCOMMd1cddf319e6f: [native] Rip `LegacyThreadInfo` out of `native/chat` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMd1cddf319e6f: [native] Rip `LegacyThreadInfo` out of `native/chat`.

Revision Contents
Changeset List

Diff 34158

View Options

native/chat/chat-thread-list-item.react.js

Loading...
View Options

native/chat/chat-thread-list-see-more-sidebars.react.js

Loading...
View Options

native/chat/chat-thread-list-sidebar.react.js

Loading...
View Options

native/chat/chat-thread-list.react.js

Loading...
View Options

native/chat/compose-subchannel.react.js

Loading...
View Options

native/chat/sidebar-list-modal.react.js

Loading...
View Options

native/chat/subchannels-list-modal.react.js

Loading...
View Options

native/chat/swipeable-thread.react.js

Loading...
View Options

native/chat/thread-list-modal.react.js

Loading...