Page MenuHomePhabricator
Differential D10340

[tunnelbroker] Switch Tunnelbroker unit tests to autoscaling CI runners
ClosedPublic
Actions

Authored by atul on Dec 14 2023, 10:35 AM.
Tags
None
Referenced Files
F6260466: D10340.id.diff
Fri, Apr 25, 8:45 AM
Unknown Object (File)
Fri, Apr 25, 2:08 AM
Unknown Object (File)
Fri, Apr 25, 12:57 AM
Unknown Object (File)
Thu, Apr 24, 10:50 PM
Unknown Object (File)
Thu, Apr 24, 9:37 AM
Unknown Object (File)
Fri, Apr 4, 2:27 PM
Unknown Object (File)
Mar 20 2025, 2:57 PM
Unknown Object (File)
Mar 20 2025, 2:57 PM
View All 97 Files
Subscribers
None

Details

Reviewers
ginsu
tomek
bartek
varun
ashoat
rohan
Commits
rCOMM1a7b52ca376b: [tunnelbroker] Switch Tunnelbroker unit tests to autoscaling CI runners
Summary

Pretty much identical to D10328 and D10339, but for Tunnelbroker.

Context: https://linear.app/comm/issue/ENG-5770/office-mba-runner-out-of-storage#comment-d61c38e9

Test Plan

See if CI passes

e6a7a7.png (924×2 px, 249 KB)

Diff Detail

Repository
rCOMM Comm
Branch
autoscaling (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul updated this revision to Diff 34650.Dec 14 2023, 10:35 AM
atul created this revision.

update herald

atul published this revision for review.Dec 14 2023, 10:41 AM
atul edited the test plan for this revision. (Show Details)
atul mentioned this in D10341: [emscripten] Switch Emscripten CI job to autoscaling runners.Dec 14 2023, 10:44 AM
Harbormaster completed remote builds in B25083: Diff 34650.Dec 14 2023, 11:10 AM
Harbormaster completed remote builds in B25082: Diff 34649.Dec 14 2023, 11:21 AM
rohan resigned from this revision.Dec 14 2023, 12:40 PM

I don't think I have enough knowledge here to be helpful, but feel free to re-add me if anything comes up

varun added inline comments.Dec 14 2023, 10:24 PM
.buildkite/tunnelbroker_unittests.yml
4–5

again wondering if we really need to install all of this stuff

ashoat resigned from this revision.Dec 14 2023, 10:49 PM

I think one of the Rust people is a better reviewer for this

bartek added inline comments.Dec 15 2023, 3:06 AM
.buildkite/tunnelbroker_unittests.yml
4–5

I think we need protobuf, just to build the project for testing
In all services we use grpc-clients crate which has tonic-build build dependency -> prost-build which requires protoc executable. And protoc is part of protobuf

bartek accepted this revision.Dec 15 2023, 3:06 AM
This revision is now accepted and ready to land.Dec 15 2023, 3:06 AM
bartek mentioned this in D10339: [identity] Switch Identity unit tests to autoscaling CI runners.Dec 15 2023, 3:07 AM
atul added inline comments.Dec 19 2023, 12:10 AM
.buildkite/tunnelbroker_unittests.yml
4–5

yeah, get an error from cargo if protoc isn't available

Closed by commit rCOMM1a7b52ca376b: [tunnelbroker] Switch Tunnelbroker unit tests to autoscaling CI runners (authored by atul). · Explain WhyDec 19 2023, 12:15 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM1a7b52ca376b: [tunnelbroker] Switch Tunnelbroker unit tests to autoscaling CI runners.
atul mentioned this in rCOMM1c776334d2ce: [emscripten] Switch Emscripten CI job to autoscaling runners.Dec 20 2023, 2:53 PM

Revision Contents
Changeset List

PathSize
.buildkite/
15 lines

Diff 34650

View Options

.buildkite/tunnelbroker_unittests.yml

Loading...