Details

Reviewers

michal
kamil
ginsu
tomek
ashoat

Commits

rCOMM24e16d686fb5: [lib] Add connectionIssue field

Summary

issue: https://linear.app/comm/issue/ENG-5990/add-setconnectionissue-action
In this stack I will be replacing logouts dispatched from the socket with seting this new connectionIssue filed. This is because we don't want to log the user out of the app if we can't connect to one keyserver. We also don't want to log the user out of this keyserver, because that would result in the client removing the keyserver from the store. Instead, we decided to store information about the problem that the client is having with communicating with the keyserver.
See the discussion in ENG-5808 for more details. See ENG-5913 for an explanation of why it takes those values.

Test Plan

flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Dec 11 2023, 1:59 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 11 2023, 1:59 AM

inka edited the summary of this revision. (Show Details)Dec 11 2023, 2:03 AM

inka added a child revision: D10288: [lib] Add setConnectionIssueActionType.Dec 11 2023, 2:07 AM

Harbormaster completed remote builds in B24934: Diff 34468.Dec 11 2023, 2:23 AM

inka requested review of this revision.Dec 11 2023, 2:23 AM

I might need to simplify this after D10289

Simplify

Harbormaster completed remote builds in B24937: Diff 34471.Dec 11 2023, 5:42 AM

ginsu accepted this revision.Dec 14 2023, 9:30 AM

This revision is now accepted and ready to land.Dec 14 2023, 9:30 AM

inka added a reviewer: tomek.Dec 19 2023, 2:23 AM

inka mentioned this in D10332: [lib][web][native] Stop logging out from the Socket.Dec 19 2023, 3:30 AM

Changes to address feedback on D10332

inka added a reviewer: ashoat.Dec 20 2023, 1:34 AM

This revision now requires review to proceed.Dec 20 2023, 1:34 AM

Harbormaster completed remote builds in B25243: Diff 34872.Dec 20 2023, 1:51 AM

tomek accepted this revision.Dec 20 2023, 4:11 AM

tomek added inline comments.

lib/types/socket-types.js
499 ↗	(On Diff #34872)	Wondering how convenient it is. In some reducers, it might be easier to set `connectionIssue: null`, which would require having `?ConnectionIssue` type, but up to you.