Page MenuHomePhabricator
Differential D10458

[lib] Rename threadInfos to resolvedThreadInfos in getChatMentionCandidates
ClosedPublic
Actions

Authored by rohan on Dec 26 2023, 9:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 9:08 AM
Unknown Object (File)
Thu, Apr 3, 12:52 AM
Unknown Object (File)
Sat, Mar 29, 7:12 PM
Unknown Object (File)
Wed, Mar 19, 4:21 AM
Unknown Object (File)
Mar 5 2025, 8:15 AM
Unknown Object (File)
Mar 5 2025, 6:40 AM
Unknown Object (File)
Mar 5 2025, 6:39 AM
Unknown Object (File)
Mar 5 2025, 6:39 AM
View All 72 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
ginsu
inka
ashoat
Commits
rCOMM87b294ac9410: [lib] Rename threadInfos to resolvedThreadInfos in getChatMentionCandidates
Summary

Just a quick rename diff to make it clear that the thread infos passed in are resolved. I'm doing this because the following diffs will involve passing in the unresolved ThreadInfos as a parameter alongside the resolved thread infos.

Part of ENG-5436

Test Plan

Ran flow to confirm no errors

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
components/
32 lines

Diff 35003

View Options

lib/components/chat-mention-provider.react.js

#include "DeviceSessionItem.h" #include "DeviceSessionItem.h"
#include "ConfigManager.h" #include "ConfigManager.h"
#include "Tools.h"
#include <vector>
namespace comm { namespace comm {
namespace network { namespace network {
namespace database { namespace database {
const std::string DeviceSessionItem::FIELD_SESSION_ID = "SessionId"; const std::string DeviceSessionItem::FIELD_SESSION_ID = "SessionId";
const std::string DeviceSessionItem::FIELD_DEVICE_ID = "DeviceId"; const std::string DeviceSessionItem::FIELD_DEVICE_ID = "DeviceId";
const std::string DeviceSessionItem::FIELD_PUBKEY = "PubKey"; const std::string DeviceSessionItem::FIELD_PUBKEY = "PubKey";
Show All 21 Lines : sessionID(sessionID),
deviceOs(deviceOs) { deviceOs(deviceOs) {
this->validate(); this->validate();
} }
DeviceSessionItem::DeviceSessionItem(const AttributeValues &itemFromDB) { DeviceSessionItem::DeviceSessionItem(const AttributeValues &itemFromDB) {
this->assignItemFromDatabase(itemFromDB); this->assignItemFromDatabase(itemFromDB);
} }
void DeviceSessionItem::validate() const { void DeviceSessionItem::validate() const {
maxAuthorUnsubmitted
Done
Inline Actions

Note: SessionID and DeviceID validations were added at the child D3526 diff.

max: Note: SessionID and DeviceID validations were added at the child D3526 diff.
if (!this->sessionID.size()) { checkEmptyField("pubKey", this->pubKey);
throw std::runtime_error("Error: SessionID is empty."); checkEmptyField("notifyToken", this->notifyToken);
} checkEmptyField("deviceType", this->deviceType);
checkEmptyField("appVersion", this->appVersion);
checkEmptyField("deviceOs", this->deviceOs);
} }
void DeviceSessionItem::assignItemFromDatabase( void DeviceSessionItem::assignItemFromDatabase(
const AttributeValues &itemFromDB) { const AttributeValues &itemFromDB) {
try { try {
this->sessionID = itemFromDB.at(DeviceSessionItem::FIELD_SESSION_ID).GetS(); this->sessionID = itemFromDB.at(DeviceSessionItem::FIELD_SESSION_ID).GetS();
this->deviceID = itemFromDB.at(DeviceSessionItem::FIELD_DEVICE_ID).GetS(); this->deviceID = itemFromDB.at(DeviceSessionItem::FIELD_DEVICE_ID).GetS();
this->pubKey = itemFromDB.at(DeviceSessionItem::FIELD_PUBKEY).GetS(); this->pubKey = itemFromDB.at(DeviceSessionItem::FIELD_PUBKEY).GetS();
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines