Paths

Table of Contentst

Differential D10459

[lib] Pass in threadInfos into getChatMentionCandidates
ClosedPublic
Actions

Authored by rohan on Dec 26 2023, 9:48 AM.

Tags

None

Referenced Files

	F1798443: D10459.id.diff
	Mon, May 20, 1:32 AM

	F1798412: D10459.id35093.diff
	Mon, May 20, 1:30 AM

	F1797981: D10459.id35004.diff
	Mon, May 20, 12:27 AM

	Unknown Object (File)
	Thu, May 9, 4:40 AM

	Unknown Object (File)
	Apr 8 2024, 7:35 PM

	Unknown Object (File)
	Mar 6 2024, 10:10 PM

	Unknown Object (File)
	Mar 6 2024, 10:09 PM

	Unknown Object (File)
	Mar 6 2024, 10:07 PM

View All 22 Files

Subscribers

Details

Reviewers

atul
ginsu
inka
ashoat

Commits

rCOMMf0db11d1b4e7: [lib] Pass in threadInfos into getChatMentionCandidates

Summary

Small diff to just pass in threadInfos into getChatMentionCandidates, since the next diff will use it. The next diff has a lot of changes to deal with Flow, so I thought separating this small change into its own diff made sense. If the reviewers disagree, I'm happy to merge this with the diff that uses threadInfos.

Part of ENG-5436

Depends on D10458

Test Plan

Ran flow again since there are no real changes to test here

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Dec 26 2023, 9:48 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 26 2023, 9:48 AM

Rebase

rohan added a child revision: D10460: [lib/web/native] Update ChatMentionCandidates type to include a rawChatName.Dec 26 2023, 9:58 AM

Harbormaster completed remote builds in B25335: Diff 35004.Dec 26 2023, 10:07 AM

Harbormaster completed remote builds in B25337: Diff 35006.Dec 26 2023, 10:22 AM

rohan requested review of this revision.Dec 26 2023, 10:22 AM

ashoat accepted this revision.Dec 26 2023, 10:44 AM

This revision is now accepted and ready to land.Dec 26 2023, 10:44 AM

Closed by commit rCOMMf0db11d1b4e7: [lib] Pass in threadInfos into getChatMentionCandidates (authored by rohan). · Explain WhyDec 29 2023, 8:14 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMMf0db11d1b4e7: [lib] Pass in threadInfos into getChatMentionCandidates.

Revision Contents
Changeset List

Path

Size

lib/

components/

chat-mention-provider.react.js

11 lines

Diff 35093

lib/components/chat-mention-provider.react.js

Loading...