[native] identity password login on native
ClosedPublic
Actions

Authored by varun on Jan 26 2024, 7:10 AM.

Details

Reviewers

ashoat
inka
tomek

Commits

rCOMM0df178291969: [native] identity password login on native

Summary

can now successfully log in to the identity service from native with username/password if usingCommServicesAccessToken is enabled

Depends on D10828

Test Plan

log in to identity service from native. also check that the correct error message is displayed if a user isn't registered or app is out of date

Diff Detail

Repository

rCOMM Comm

Branch

deleteuser (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Jan 26 2024, 7:10 AM

going to first fix the prekey and one time key logic earlier in the stack. shouldn't change anything here, but just in case, i don't want to waste reviewers' time

Harbormaster completed remote builds in B26185: Diff 36167.Jan 26 2024, 7:30 AM

varun added a child revision: D10880: [lib][native][web] add generate nonce action types.Jan 30 2024, 8:22 PM

address feedback

Harbormaster completed remote builds in B26453: Diff 36571.Feb 1 2024, 10:34 PM

ashoat accepted this revision.Feb 2 2024, 7:36 AM

This revision is now accepted and ready to land.Feb 2 2024, 7:36 AM

Closed by commit rCOMM0df178291969: [native] identity password login on native (authored by varun). · Explain WhyFeb 7 2024, 9:57 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM0df178291969: [native] identity password login on native.

Revision Contents
Changeset List

Path

Size

native/

account/

log-in-panel.react.js

74 lines

Diff 36167

View Options

native/account/log-in-panel.react.js

[native] identity password login on nativeClosedPublicActions