The reaction tooltip was not properly resoving ens usernames. This diff fixes that issue
Linear task: https://linear.app/comm/issue/ENG-5917/reactions-list-doesnt-appear-to-be-ens-resolved
Differential D10419
[web] ens resolve usernames in the reaction tooltip ginsu on Dec 20 2023, 6:06 PM. Authored by Tags None Referenced Files
Details
The reaction tooltip was not properly resoving ens usernames. This diff fixes that issue Linear task: https://linear.app/comm/issue/ENG-5917/reactions-list-doesnt-appear-to-be-ens-resolved Please see screenshots below before: after:
Diff Detail
Event TimelineComment Actions Just requesting changes so its back in your queue. Let me know if my testing was missing something Comment Actions Is there some missing context here? It sounds like @rohan did some testing and things didn't work, but not sure what that testing was Comment Actions Ah sorry I'll add the context here. @ginsu and I spoke offline - I patched in the stack locally and changed the providers to use goerli instead of mainnet (since I have some ENS names linked to wallet addresses on the testnet). I verified that the ENS names for my users resolved in my inbox, chat, etc, but when I tried hovering over the reaction tooltip, it only showed the wallet addresses. One thing I noticed was when the useENSNames hook was called in the reaction tooltip, ensCache was always undefined so we'd early return. I wasn't sure if that was the cause for them not resolving in the reaction tooltip for me. Edit: Not sure if it's helpful. but when I move the AlchemyENSCacheProvider above TooltipProvider in app.react.js, the ENS names are resolved now Comment Actions
This is super helpful @rohan! Thanks for taking a look at this! I will update the diff once I can properly sign in w/ eth and better test this out myself. (I actually managed to resolve a lot of my metamask linking issues today) Comment Actions
Yes, updated the diff, test plan + reviewers (previously had rohan but he's no longer here) to reflect the new changes I made |