This implements the types associated with identity search messages to be used by identity search context provider
Depends on D11125
Details
Details
flow
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- wyilio/prefix-client
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/types/identity-search/search-query-types.js | ||
|---|---|---|
| 8 | SearchQuery is set equal to Prefix as I have yet to implement other search options | |
| lib/types/identity-search/messages.js | ||
|---|---|---|
| 27 | Are you sure we want to use a single enum for messages that either side sends? Or should we separate the message types between server/client? | |
| lib/types/identity-search/messages.js | ||
|---|---|---|
| 27 | Agreed. Would definitely make this more organized. Was following Tunnelbroker conventions, but this would make type checking airtight on client end. Will implement these changes | |
| lib/types/identity-search/messages.js | ||
|---|---|---|
| 27 | Rust addressed in https://phab.comm.dev/D10945 and updated review to separate server/client message types | |
| lib/types/identity-search/messages.js | ||
|---|---|---|
| 27–37 ↗ | (On Diff #36869) | do we need this message in other files, too? |
| lib/types/identity-search/messages.js | ||
|---|---|---|
| 27–37 ↗ | (On Diff #36869) | Yeah, I think that'd definitely be nice to have. Will add in next diff |
| lib/types/identity-search/messages.js | ||
|---|---|---|
| 27–37 ↗ | (On Diff #36869) | might be easier to just rebase and add it in this diff. if not, can you please link a linear task or diff here before landing? |
| lib/types/identity-search/messages.js | ||
|---|---|---|
| 27–37 ↗ | (On Diff #36869) | Sorry. Should have clarified. I meant I'll rebase on this diff |
| lib/types/identity-search/messages.js | ||
|---|---|---|
| 27–37 ↗ | (On Diff #37016) | i feel like this note should come before the imports |
Comment Actions
typo in AuthMessage
| lib/types/identity-search/messages.js | ||
|---|---|---|
| 27–37 ↗ | (On Diff #37016) | Moved |
| lib/types/identity-search/messages.js | ||
|---|---|---|
| 27–37 ↗ | (On Diff #36869) | Addressed in latest rebase |
Comment Actions
Please take the feedback about User and apply it to all of your named exports
| lib/types/identity-search/auth-message-types.js | ||
|---|---|---|
| 20 ↗ | (On Diff #37279) | We need to be more thoughtful about names that get exported. They should be "universal" across the JS codebase. In this case, this should be something more like IdentitySearchAuthMessage |
| 27 ↗ | (On Diff #37279) | And this should be more like identitySearchAuthMessageValidator |
| lib/types/identity-search/search-query-types.js | ||
| 22 ↗ | (On Diff #37279) | Extremely generic name |