[web] factor out creation of DeviceKeyUpload
ClosedPublic
Actions

Authored by varun on Feb 5 2024, 9:54 PM.

Details

Reviewers

Commits

Summary

we will need to create an object of this type for wallet login too, so moving the common code to a helper

Depends on D10959

Test Plan

successfully logged in to identity service on web, console logged DeviceKeyUpload to make sure it matched the contents in DDB

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

varun requested review of this revision.Feb 5 2024, 10:12 PM

tomek added inline comments.

web/grpc/identity-service-client-wrapper.js
291	I don't think that adding a protocol to the name is helpful. Instead, we could mention which endpoint we're calling.

This revision is now accepted and ready to land.Feb 6 2024, 1:00 AM

web/grpc/identity-service-client-wrapper.js
291	hmm but `DeviceKeyUpload` comes from the `grpc-web` codegen and isn't specific to the `logInPasswordUserStart` endpoint. we send this on `loginWalletUser`, `loginPasswordUserStart`, and `registerPasswordUserStart`. i'll rename it to `loginDeviceKeyUpload` since we don't support registration on web, but i think this could lead to confusion if we ever introduce another web client method that uses `DeviceKeyUpload`.