Page MenuHomePhabricator
Differential D10961

[lib][native][web] useIdentityWalletLogIn() hook
ClosedPublic
Actions

Authored by varun on Feb 5 2024, 10:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 23, 4:59 PM
Unknown Object (File)
Mon, Dec 23, 4:59 PM
Unknown Object (File)
Mon, Dec 23, 4:59 PM
Unknown Object (File)
Mon, Dec 23, 4:59 PM
Unknown Object (File)
Mon, Dec 23, 4:58 PM
Unknown Object (File)
Sat, Dec 21, 4:02 PM
Unknown Object (File)
Thu, Dec 19, 4:02 AM
Unknown Object (File)
Fri, Dec 6, 9:46 AM
View All 84 Files
Subscribers
None

Details

Reviewers
ashoat
inka
tomek
Commits
rCOMM2af4e3fcfc48: [lib][native][web] useIdentityWalletLogIn() hook
Summary

hook that will be used on web and native for SIWE

Depends on D10960

Test Plan

used the hook on web to call the identity service. siwe verification failed as expected (used a random string for the siwe message and signature) but identity logs showed that the request received contained all the correct data. siwe will be tested thoroughly in the next diffs by actually using the hook in native and web siwe components

Diff Detail

Repository
rCOMM Comm
Branch
deleteuser (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Feb 5 2024, 10:00 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 5 2024, 10:13 PM
Harbormaster failed remote builds in B26529: Diff 36666!
varun added inline comments.Feb 5 2024, 10:15 PM
native/identity-service/identity-service-context-provider.react.js
280–281 ↗(On Diff #36666)

will rebase and fix this once I resolve ENG-6666. will not land this diff before then

varun updated this revision to Diff 36667.Feb 5 2024, 10:15 PM

remove some unnecessary checks and a mistakenly added file

Harbormaster completed remote builds in B26530: Diff 36667.Feb 5 2024, 10:34 PM
varun requested review of this revision.Feb 5 2024, 10:34 PM
tomek requested changes to this revision.Feb 6 2024, 1:10 AM
tomek added inline comments.
lib/actions/user-actions.js
489–496

It seems we can significantly simplify it

web/grpc/identity-service-client-wrapper.js
305

Why this function on web requires fewer parameters than the one on native? Shouldn't they be consistent?

This revision now requires changes to proceed.Feb 6 2024, 1:10 AM
varun added inline comments.Feb 6 2024, 10:30 AM
web/grpc/identity-service-client-wrapper.js
305

the code generated web gRPC client takes a single WalletLoginRequest object (this is a generated type). we construct the object and set its fields in lines 295-301 above. on native, we just pass all of the data to the native_rust_library and construct the request object there

varun added inline comments.Feb 6 2024, 9:09 PM
lib/actions/user-actions.js
489–496

good point

varun updated this revision to Diff 36763.Feb 6 2024, 9:11 PM

address feedback

Harbormaster completed remote builds in B26606: Diff 36763.Feb 6 2024, 9:27 PM
tomek accepted this revision.Feb 7 2024, 6:06 AM
This revision is now accepted and ready to land.Feb 7 2024, 6:06 AM
Closed by commit rCOMM2af4e3fcfc48: [lib][native][web] useIdentityWalletLogIn() hook (authored by varun). · Explain WhyFeb 7 2024, 9:58 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM2af4e3fcfc48: [lib][native][web] useIdentityWalletLogIn() hook.
varun mentioned this in D11083: [lib][native] simplify and rename identity password registration hook.Feb 14 2024, 11:17 AM
varun mentioned this in rCOMM888001b3f46f: [lib][native] simplify and rename identity password registration hook.Feb 16 2024, 7:20 AM

Revision Contents
Changeset List

PathSize
lib/
actions/
20 lines
types/
5 lines
native/
identity-service/
41 lines
web/
grpc/
33 lines

Diff 36667

View Options

lib/actions/user-actions.js

Loading...
View Options

lib/types/identity-service-types.js

Loading...
View Options

native/identity-service/identity-service-context-provider.react.js

Loading...
View Options

web/grpc/identity-service-client-wrapper.js

Loading...