This differential removes sqlite orm dependency from the project.
Details
Details
- Reviewers
kamil michal varun - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rCOMM2029d7cd68a8: Remove sqlite_orm dependency from the project
Build the app.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
how about web/database/_generated/comm_query_executor.wasm? are there any updates needed there?
| web/scripts/run_emscripten.sh | ||
|---|---|---|
| 161 ↗ | (On Diff #35801) | this line is hiding this file during review, just a heads up. might want to do what we do in web/scripts/codegen-identity-grpc.sh to avoid hiding it |
Comment Actions
This diff doesn't cause any changes in web/database/_generated/comm_query_executor.wasm compared to previous diffs in the stack. I executed yarn build-db-wasm on every diff in the stack and included changes in wasm file if there were any. As of this differential sqlite_orm dependency is not used in the code so it is not compiled and hence removing the header doesn't change the binary. Finally if it changed then Emscripten CI would fail on this diff.
| web/scripts/run_emscripten.sh | ||
|---|---|---|
| 161 ↗ | (On Diff #35801) | I think Emscripten CI is enough for this purpose. If diff changes WASM but new WASM is not included then Emscripten CI will fail the diff. |