[native] Download and restore compaction
ClosedPublic
Actions

Authored by michal on Feb 7 2024, 9:48 AM.

Details

Reviewers

marcin
bartek
kamil

Commits

rCOMMdb655c09ce3a: [native] Download and restore compaction

Summary

Update the JS and Rust code to download and restore sqlite backup compaction. Logs will be handled later. After compaction and user keys are downloaded, the sqlite data is saved to a file and calls the C++ function with the path and the encryption key. After everything succeds it resolved the JS promise.

Depends on D10859

Test Plan

Enabled uploading backups
Made a new draft
Created a new compaction and waited for it to be successfuly uploaded
Logged out
Logged in, into the same account
Checked that the draft wasn't there
Restored from backup
Restarted the app so redux would refresh
Checked that the draft would be there

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Feb 7 2024, 9:48 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 7 2024, 9:48 AM

Harbormaster completed remote builds in B26625: Diff 36791.Feb 7 2024, 10:04 AM

michal requested review of this revision.Feb 7 2024, 10:04 AM

Could you please update and re-execute the test plan so that after creating draft you log-out and log-in instead of removing the draft? With you current test plan you test restoring from backup that is encrypted with the same encryption key that we already have on the device. This scenario isn't realistic enough - in practice we will always restore from backup file encrypted with different encryption key that we have on the device.

Updated the test plan to log out and in.

michal added a child revision: D11038: [native] Download and apply logs.Feb 12 2024, 7:07 AM

marcin accepted this revision.Feb 12 2024, 11:53 PM

This revision is now accepted and ready to land.Feb 12 2024, 11:53 PM

kamil accepted this revision.Feb 13 2024, 2:05 AM

Closed by commit rCOMMdb655c09ce3a: [native] Download and restore compaction (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyFeb 26 2024, 5:07 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMdb655c09ce3a: [native] Download and restore compaction.