Page MenuHomePhabricator
Differential D11107

[web] implementing getting inbound user keys in `IdentityServiceClient`
ClosedPublic
Actions

Authored by kamil on Feb 19 2024, 7:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 5:12 PM
Unknown Object (File)
Oct 23 2024, 7:24 PM
Unknown Object (File)
Oct 23 2024, 7:24 PM
Unknown Object (File)
Oct 23 2024, 7:24 PM
Unknown Object (File)
Oct 23 2024, 7:21 PM
Unknown Object (File)
Oct 18 2024, 7:39 AM
Unknown Object (File)
Oct 10 2024, 5:56 AM
Unknown Object (File)
Oct 10 2024, 4:11 AM
View All 52 Files
Subscribers
ashoat

Details

Reviewers
marcin
varun
tomek
Commits
rCOMM359e1357eb20: [web] implementing getting inbound user keys in `IdentityServiceClient`
Summary

Call RPC to get the keys of all devices of a given user. In case of inbound session we know the device(s)ID so it's more convenient to return object than array.

Depends on D11106

Test Plan

Call method and log result

Diff Detail

Repository
rCOMM Comm
Branch
olm-web-4
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Feb 19 2024, 7:46 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 19 2024, 7:46 AM
kamil added a child revision: D11108: [native] implementing getting inbound user keys in `IdentityServiceClient`.Feb 19 2024, 7:55 AM
Harbormaster completed remote builds in B26965: Diff 37324.Feb 19 2024, 8:02 AM
kamil published this revision for review.Feb 19 2024, 9:35 AM
tomek accepted this revision.Feb 21 2024, 1:52 AM
tomek added inline comments.
web/grpc/identity-service-client-wrapper.js
284–288

Can we also validate username and walletAddress?

This revision is now accepted and ready to land.Feb 21 2024, 1:52 AM
kamil updated this revision to Diff 37446.Feb 22 2024, 8:03 AM

improve validation

Harbormaster failed remote builds in B27068: Diff 37446!Feb 22 2024, 8:11 AM
This revision was landed with ongoing or failed builds.Feb 23 2024, 1:32 AM
Closed by commit rCOMM359e1357eb20: [web] implementing getting inbound user keys in `IdentityServiceClient` (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM359e1357eb20: [web] implementing getting inbound user keys in `IdentityServiceClient`.

Revision Contents
Changeset List

PathSize
lib/
types/
3 lines
web/
grpc/
67 lines

Diff 37324

View Options

lib/types/identity-service-types.js

Loading...
View Options

web/grpc/identity-service-client-wrapper.js

Loading...