Page MenuHomePhabricator
Differential D11096

[shared] [identity] Prepend "IdentitySearch" to identity search struct/enum names
ClosedPublic
Actions

Authored by will on Feb 15 2024, 12:28 PM.
Tags
None
Referenced Files
F3356637: D11096.diff
Sat, Nov 23, 7:44 PM
Unknown Object (File)
Wed, Nov 13, 12:48 PM
Unknown Object (File)
Tue, Nov 12, 9:27 PM
Unknown Object (File)
Tue, Nov 12, 9:27 PM
Unknown Object (File)
Tue, Nov 12, 9:27 PM
Unknown Object (File)
Tue, Nov 12, 9:27 PM
Unknown Object (File)
Oct 20 2024, 4:33 AM
Unknown Object (File)
Oct 20 2024, 1:43 AM
View All 64 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMM5e61b69b94e4: [shared] [identity] Prepend "IdentitySearch" to identity search struct/enum…
Summary

This renames the shared identity search message types to include "IdentitySearch"

Test Plan

cargo check

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Feb 15 2024, 12:28 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 15 2024, 12:28 PM
will added a child revision: D10980: [identity] [shared] Change search query enum to struct and introduce search method enum.Feb 15 2024, 12:30 PM
will mentioned this in D11060: [web] Change identity search function return type to GlobalUserInfo.Feb 15 2024, 12:47 PM
Harbormaster completed remote builds in B26933: Diff 37274.Feb 15 2024, 12:48 PM
will requested review of this revision.Feb 15 2024, 12:48 PM
will planned changes to this revision.Feb 15 2024, 2:01 PM
will updated this revision to Diff 37359.Feb 20 2024, 6:58 AM

Append IdentitySearch to all message types

will retitled this revision from [shared] [identity] Rename Generic User type to IdentitySearchUser to [shared] [identity] Prepend "IdentitySearch" to identity search struct/enum names.Feb 20 2024, 7:01 AM
will edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B26999: Diff 37359.Feb 20 2024, 7:14 AM
varun accepted this revision.Feb 22 2024, 8:27 PM
This revision is now accepted and ready to land.Feb 22 2024, 8:27 PM
Closed by commit rCOMM5e61b69b94e4: [shared] [identity] Prepend "IdentitySearch" to identity search struct/enum… (authored by will). · Explain WhyFeb 25 2024, 7:24 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM5e61b69b94e4: [shared] [identity] Prepend "IdentitySearch" to identity search struct/enum….

Revision Contents
Changeset List

PathSize
services/
identity/
src/
websockets/
4 lines
14 lines
shared/
identity_search_messages/
src/
messages/
2 lines
6 lines
6 lines
6 lines

Diff 37359

View Options

services/identity/src/websockets/auth.rs

Loading...
View Options

services/identity/src/websockets/mod.rs

Loading...
View Options

shared/identity_search_messages/src/messages/auth_messages.rs

Loading...
View Options

shared/identity_search_messages/src/messages/mod.rs

Loading...
View Options

shared/identity_search_messages/src/messages/search_query.rs

Loading...
View Options

shared/identity_search_messages/src/messages/search_result.rs

Loading...