Page MenuHomePhabricator
Differential D11112

[crypto] implement creating `olm` inbound session
ClosedPublic
Actions

Authored by kamil on Feb 19 2024, 9:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 13, 2:44 AM
Unknown Object (File)
Sat, Mar 1, 6:42 PM
Unknown Object (File)
Feb 24 2025, 2:45 AM
Unknown Object (File)
Feb 23 2025, 6:07 AM
Unknown Object (File)
Feb 22 2025, 10:47 AM
Unknown Object (File)
Feb 22 2025, 10:47 AM
Unknown Object (File)
Feb 22 2025, 10:47 AM
Unknown Object (File)
Feb 22 2025, 10:47 AM
View All 71 Files
Subscribers
ashoat

Details

Reviewers
marcin
varun
tomek
Commits
rCOMMa49cc2b6b26f: [crypto] implement creating `olm` inbound session
Summary

Shared code to create inbound session.

Depends on D11111

Test Plan

native: was tested previously - here only adding function to interface
web: call this method with properly generated account and keys

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Feb 19 2024, 9:54 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 19 2024, 9:54 AM
Harbormaster completed remote builds in B26977: Diff 37336.Feb 19 2024, 10:09 AM
kamil published this revision for review.Feb 20 2024, 4:06 AM
kamil added inline comments.
native/crypto/olm-api.js
21–24 ↗(On Diff #37336)

this could be avoided after ENG-6429

kamil added a child revision: D11119: [crypto] implement getting one-time keys in `OlmAPI`.Feb 20 2024, 5:28 AM
tomek accepted this revision.Feb 21 2024, 2:58 AM
tomek added inline comments.
web/crypto/olm-api.js
58–64 ↗(On Diff #37336)

What is the reason behind this inconsistency? Can we have similar layers on both platforms?

This revision is now accepted and ready to land.Feb 21 2024, 2:58 AM
kamil updated this revision to Diff 37587.Feb 26 2024, 3:16 AM

rebase

Harbormaster failed remote builds in B27167: Diff 37587!Feb 26 2024, 4:37 AM
kamil added inline comments.Feb 26 2024, 4:46 AM
web/crypto/olm-api.js
58–64 ↗(On Diff #37336)

this is explained in this comment: https://phab.comm.dev/D11111#inline-67456

This revision was landed with ongoing or failed builds.Feb 26 2024, 5:46 AM
Closed by commit rCOMMa49cc2b6b26f: [crypto] implement creating `olm` inbound session (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMa49cc2b6b26f: [crypto] implement creating `olm` inbound session.
Harbormaster completed remote builds in B27167: Diff 37587.Feb 26 2024, 3:31 PM

Revision Contents
Changeset List

PathSize
lib/
types/
4 lines
native/
crypto/
16 lines
web/
crypto/
24 lines

Diff 37601

View Options

lib/types/crypto-types.js

Show All 12 Linesimport {
entryRevisionFetchResponder, entryRevisionFetchResponder,
entryCreationResponder, entryCreationResponder,
entryUpdateResponder, entryUpdateResponder,
entryDeletionResponder, entryDeletionResponder,
entryRestorationResponder, entryRestorationResponder,
calendarQueryUpdateResponder, calendarQueryUpdateResponder,
} from './responders/entry-responders.js'; } from './responders/entry-responders.js';
import type { JSONResponder } from './responders/handlers.js'; import type { JSONResponder } from './responders/handlers.js';
import { getSessionPublicKeysResponder } from './responders/keys-responders.js'; import {
getSessionPublicKeysResponder,
getOlmSessionInitializationDataResponder,
} from './responders/keys-responders.js';
import { inviteLinkVerificationResponder } from './responders/link-responders.js'; import { inviteLinkVerificationResponder } from './responders/link-responders.js';
import { messageReportCreationResponder } from './responders/message-report-responder.js'; import { messageReportCreationResponder } from './responders/message-report-responder.js';
import { import {
textMessageCreationResponder, textMessageCreationResponder,
messageFetchResponder, messageFetchResponder,
multimediaMessageCreationResponder, multimediaMessageCreationResponder,
reactionMessageCreationResponder, reactionMessageCreationResponder,
editMessageCreationResponder, editMessageCreationResponder,
▲ Show 20 Lines • Show All 239 Lines • ▼ Show 20 Linesconst jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
update_user_avatar: { update_user_avatar: {
responder: updateUserAvatarResponder, responder: updateUserAvatarResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
upload_media_metadata: { upload_media_metadata: {
responder: uploadMediaMetadataResponder, responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
get_olm_session_initialization_data: {
responder: getOlmSessionInitializationDataResponder,
requiredPolicies: [],
},
}; };
export { jsonEndpoints }; export { jsonEndpoints };
View Options

native/crypto/olm-api.js

Show All 12 Linesimport {
entryRevisionFetchResponder, entryRevisionFetchResponder,
entryCreationResponder, entryCreationResponder,
entryUpdateResponder, entryUpdateResponder,
entryDeletionResponder, entryDeletionResponder,
entryRestorationResponder, entryRestorationResponder,
calendarQueryUpdateResponder, calendarQueryUpdateResponder,
} from './responders/entry-responders.js'; } from './responders/entry-responders.js';
import type { JSONResponder } from './responders/handlers.js'; import type { JSONResponder } from './responders/handlers.js';
import { getSessionPublicKeysResponder } from './responders/keys-responders.js'; import {
getSessionPublicKeysResponder,
getOlmSessionInitializationDataResponder,
} from './responders/keys-responders.js';
import { inviteLinkVerificationResponder } from './responders/link-responders.js'; import { inviteLinkVerificationResponder } from './responders/link-responders.js';
import { messageReportCreationResponder } from './responders/message-report-responder.js'; import { messageReportCreationResponder } from './responders/message-report-responder.js';
import { import {
textMessageCreationResponder, textMessageCreationResponder,
messageFetchResponder, messageFetchResponder,
multimediaMessageCreationResponder, multimediaMessageCreationResponder,
reactionMessageCreationResponder, reactionMessageCreationResponder,
editMessageCreationResponder, editMessageCreationResponder,
▲ Show 20 Lines • Show All 239 Lines • ▼ Show 20 Linesconst jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
update_user_avatar: { update_user_avatar: {
responder: updateUserAvatarResponder, responder: updateUserAvatarResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
upload_media_metadata: { upload_media_metadata: {
responder: uploadMediaMetadataResponder, responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
get_olm_session_initialization_data: {
responder: getOlmSessionInitializationDataResponder,
requiredPolicies: [],
},
}; };
export { jsonEndpoints }; export { jsonEndpoints };
View Options

web/crypto/olm-api.js

Show All 12 Linesimport {
entryRevisionFetchResponder, entryRevisionFetchResponder,
entryCreationResponder, entryCreationResponder,
entryUpdateResponder, entryUpdateResponder,
entryDeletionResponder, entryDeletionResponder,
entryRestorationResponder, entryRestorationResponder,
calendarQueryUpdateResponder, calendarQueryUpdateResponder,
} from './responders/entry-responders.js'; } from './responders/entry-responders.js';
import type { JSONResponder } from './responders/handlers.js'; import type { JSONResponder } from './responders/handlers.js';
import { getSessionPublicKeysResponder } from './responders/keys-responders.js'; import {
getSessionPublicKeysResponder,
getOlmSessionInitializationDataResponder,
} from './responders/keys-responders.js';
import { inviteLinkVerificationResponder } from './responders/link-responders.js'; import { inviteLinkVerificationResponder } from './responders/link-responders.js';
import { messageReportCreationResponder } from './responders/message-report-responder.js'; import { messageReportCreationResponder } from './responders/message-report-responder.js';
import { import {
textMessageCreationResponder, textMessageCreationResponder,
messageFetchResponder, messageFetchResponder,
multimediaMessageCreationResponder, multimediaMessageCreationResponder,
reactionMessageCreationResponder, reactionMessageCreationResponder,
editMessageCreationResponder, editMessageCreationResponder,
▲ Show 20 Lines • Show All 239 Lines • ▼ Show 20 Linesconst jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
update_user_avatar: { update_user_avatar: {
responder: updateUserAvatarResponder, responder: updateUserAvatarResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
upload_media_metadata: { upload_media_metadata: {
responder: uploadMediaMetadataResponder, responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
get_olm_session_initialization_data: {
responder: getOlmSessionInitializationDataResponder,
requiredPolicies: [],
},
}; };
export { jsonEndpoints }; export { jsonEndpoints };