Page MenuHomePhabricator
Differential D11112

[crypto] implement creating `olm` inbound session
ClosedPublic
Actions

Authored by kamil on Feb 19 2024, 9:54 AM.
Tags
None
Referenced Files
F3348621: D11112.id37336.diff
Fri, Nov 22, 3:30 PM
Unknown Object (File)
Fri, Nov 8, 5:20 PM
Unknown Object (File)
Fri, Nov 8, 5:12 PM
Unknown Object (File)
Oct 18 2024, 3:05 PM
Unknown Object (File)
Oct 18 2024, 3:05 PM
Unknown Object (File)
Oct 18 2024, 3:05 PM
Unknown Object (File)
Oct 18 2024, 3:04 PM
Unknown Object (File)
Oct 18 2024, 7:10 AM
View All 51 Files
Subscribers
ashoat

Details

Reviewers
marcin
varun
tomek
Commits
rCOMMa49cc2b6b26f: [crypto] implement creating `olm` inbound session
Summary

Shared code to create inbound session.

Depends on D11111

Test Plan

native: was tested previously - here only adding function to interface
web: call this method with properly generated account and keys

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Feb 19 2024, 9:54 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 19 2024, 9:54 AM
Harbormaster completed remote builds in B26977: Diff 37336.Feb 19 2024, 10:09 AM
kamil published this revision for review.Feb 20 2024, 4:06 AM
kamil added inline comments.
native/crypto/olm-api.js
21–24 ↗(On Diff #37336)

this could be avoided after ENG-6429

kamil added a child revision: D11119: [crypto] implement getting one-time keys in `OlmAPI`.Feb 20 2024, 5:28 AM
tomek accepted this revision.Feb 21 2024, 2:58 AM
tomek added inline comments.
web/crypto/olm-api.js
58–64 ↗(On Diff #37336)

What is the reason behind this inconsistency? Can we have similar layers on both platforms?

This revision is now accepted and ready to land.Feb 21 2024, 2:58 AM
kamil updated this revision to Diff 37587.Feb 26 2024, 3:16 AM

rebase

Harbormaster failed remote builds in B27167: Diff 37587!Feb 26 2024, 4:37 AM
kamil added inline comments.Feb 26 2024, 4:46 AM
web/crypto/olm-api.js
58–64 ↗(On Diff #37336)

this is explained in this comment: https://phab.comm.dev/D11111#inline-67456

This revision was landed with ongoing or failed builds.Feb 26 2024, 5:46 AM
Closed by commit rCOMMa49cc2b6b26f: [crypto] implement creating `olm` inbound session (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMa49cc2b6b26f: [crypto] implement creating `olm` inbound session.
Harbormaster completed remote builds in B27167: Diff 37587.Feb 26 2024, 3:31 PM

Revision Contents
Changeset List

PathSize
lib/
types/
4 lines
native/
crypto/
16 lines
web/
crypto/
24 lines

Diff 37601

View Options

lib/types/crypto-types.js

Loading...
View Options

native/crypto/olm-api.js

Loading...
View Options

web/crypto/olm-api.js

Loading...