[lib] fix creating Tunnelbroker socket
ClosedPublic
Actions

Authored by kamil on Mar 4 2024, 7:25 AM.

Details

Reviewers

bartek
michal

Commits

rCOMMbe9961691484: [lib] fix creating Tunnelbroker socket

Summary

ENG-6875.

Previous code was creating multiple sockets on each re-render which was causing issues.

Test Plan

Add credentials and test if connection with Tunnelbroker works.

Diff Detail

Repository

rCOMM Comm

Branch

fix-web-tb-socket

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Mar 4 2024, 7:25 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 4 2024, 7:25 AM

Harbormaster completed remote builds in B27301: Diff 37783.Mar 4 2024, 7:47 AM

kamil published this revision for review.Mar 4 2024, 9:22 AM

bartek accepted this revision.Mar 4 2024, 9:54 PM

This revision is now accepted and ready to land.Mar 4 2024, 9:54 PM

rebase

Harbormaster completed remote builds in B27318: Diff 37803.Mar 5 2024, 1:53 AM

Closed by commit rCOMMbe9961691484: [lib] fix creating Tunnelbroker socket (authored by kamil). · Explain WhyMar 5 2024, 1:55 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMbe9961691484: [lib] fix creating Tunnelbroker socket.

Revision Contents
Changeset List

Path

Size

lib/

tunnelbroker/

tunnelbroker-context.js

9 lines

Diff 37783

View Options

lib/tunnelbroker/tunnelbroker-context.js

Show First 20 Lines • Show All 593 Lines • ▼ Show 20 Lines	const animatedContent = (
</Animated.View>		</Animated.View>
);		);

let siwePanel;		let siwePanel;
if (this.state.mode === 'siwe') {		if (this.state.mode === 'siwe') {
siwePanel = (		siwePanel = (
<SIWEPanel		<SIWEPanel
onClose={this.goBackToPrompt}		onClose={this.goBackToPrompt}
nextMode={this.state.nextMode}		closing={this.state.nextMode === 'prompt'}
/>		/>
);		);
}		}

const backgroundSource = { uri: splashBackgroundURI };		const backgroundSource = { uri: splashBackgroundURI };
return (		return (
<React.Fragment>		<React.Fragment>
<ConnectedStatusBar barStyle="light-content" />		<ConnectedStatusBar barStyle="light-content" />
▲ Show 20 Lines • Show All 188 Lines • Show Last 20 Lines

[lib] fix creating Tunnelbroker socketClosedPublicActions