Page MenuHomePhabricator
Differential D11382

[lib] Rename `UPDATE_RELATIONSHIP` message type to `LEGACY_UPDATE...`
ClosedPublic
Actions

Authored by atul on Mar 25 2024, 1:31 PM.
Tags
None
Referenced Files
F3392618: D11382.id38343.diff
Sat, Nov 30, 9:29 AM
F3392561: D11382.id38342.diff
Sat, Nov 30, 9:13 AM
Unknown Object (File)
Mon, Nov 25, 11:28 PM
Unknown Object (File)
Tue, Nov 12, 9:15 PM
Unknown Object (File)
Tue, Nov 12, 9:15 PM
Unknown Object (File)
Tue, Nov 12, 9:15 PM
Unknown Object (File)
Tue, Nov 12, 9:15 PM
Unknown Object (File)
Tue, Nov 12, 9:15 PM
View All 76 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
varun
will
Commits
rCOMM91b21c0873ea: [lib] Rename `UPDATE_RELATIONSHIP` message type to `LEGACY_UPDATE...`
Summary

We're going to create a new version of UPDATE_RELATIONSHIP which can support the farcaster_mutual action.

Depends on D11381

Test Plan

Straightforward rename. flow + CI

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Mar 25 2024, 1:31 PM
Herald added a subscriber: tomek. · View Herald TranscriptMar 25 2024, 1:31 PM
atul updated this revision to Diff 38306.Mar 25 2024, 1:34 PM

Include test name change.

Harbormaster completed remote builds in B27673: Diff 38305.Mar 25 2024, 1:46 PM
Harbormaster completed remote builds in B27674: Diff 38306.Mar 25 2024, 1:49 PM
atul requested review of this revision.Mar 25 2024, 1:49 PM
will accepted this revision.Mar 25 2024, 2:15 PM
This revision is now accepted and ready to land.Mar 25 2024, 2:15 PM
atul added a child revision: D11383: [CommCoreModule] MessageSpec changes for updated `UPDATE_RELATIONSHIP`.Mar 25 2024, 5:57 PM
atul updated this revision to Diff 38342.Mar 26 2024, 12:11 PM

rebase and land

This revision was landed with ongoing or failed builds.Mar 26 2024, 12:25 PM
Closed by commit rCOMM91b21c0873ea: [lib] Rename `UPDATE_RELATIONSHIP` message type to `LEGACY_UPDATE...` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM91b21c0873ea: [lib] Rename `UPDATE_RELATIONSHIP` message type to `LEGACY_UPDATE...`.
Harbormaster completed remote builds in B27687: Diff 38342.Mar 26 2024, 12:27 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
updaters/
4 lines
lib/
shared/
6 lines
messages/
2 lines
6 lines
2 lines
types/
2 lines
messages/
2 lines
2 lines
native/
redux/
2 lines

Diff 38305

View Options

keyserver/src/updaters/relationship-updaters.js

Loading...
View Options

lib/shared/message-utils.test.js

Loading...
View Options

lib/shared/messages/message-specs.js

Loading...
View Options

lib/shared/messages/update-relationship-message-spec.js

Loading...
View Options

lib/shared/unshim-utils.js

Loading...
View Options

lib/types/message-types-enum.js

Loading...
View Options

lib/types/messages/update-relationship.js

Loading...
View Options

lib/types/validation.test.js

Loading...
View Options

native/redux/persist.js

Loading...