[lib] Update `messageContentFor[Client/Server]DB` to handle `UpdateRelationship`
ClosedPublic
Actions

Authored by atul on Mar 28 2024, 9:59 AM.

Details

Reviewers

ginsu
tomek
will
varun

Commits

rCOMM6c7bca7377b6: [lib] Update `messageContentFor[Client/Server]DB` to handle `UpdateRelationship`

Summary

Based on https://github.com/CommE2E/comm/commit/c46628b1139850005d11f057298d18896b1af30d and https://github.com/CommE2E/comm/commit/06cb5b0bd357b1d02aaf858eb0cd57ab5996cde9 from hackathon branch

Depends on D11439

Test Plan

This should be a noop, flow. Checked MariaDB messages table after subsequent diffs to make sure that neynar_mutual appeared as expected: https://blob.sh/9c626e.png

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 28 2024, 9:59 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 28 2024, 9:59 AM

atul published this revision for review.Mar 28 2024, 10:01 AM

Harbormaster completed remote builds in B27779: Diff 38469.Mar 28 2024, 10:15 AM

atul added a child revision: D11452: [lib] Partially update `UpdateRelationshipMessageSpec` to support updated `UpdateRelationship` message type.Mar 28 2024, 10:44 AM

ginsu accepted this revision.Mar 28 2024, 8:26 PM

This revision is now accepted and ready to land.Mar 28 2024, 8:26 PM

land

Harbormaster completed remote builds in B27992: Diff 38796.Apr 4 2024, 12:54 PM

Closed by commit rCOMM6c7bca7377b6: [lib] Update `messageContentFor[Client/Server]DB` to handle `UpdateRelationship` (authored by atul). · Explain WhyApr 4 2024, 1:00 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM6c7bca7377b6: [lib] Update `messageContentFor[Client/Server]DB` to handle `UpdateRelationship`.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

update-relationship-message-spec.js

12 lines

Diff 38796

View Options

lib/shared/messages/update-relationship-message-spec.js

Show All 13 Lines	import type {
MessageInfo,		MessageInfo,
} from '../../types/message-types.js';		} from '../../types/message-types.js';
import {		import {
type RawLegacyUpdateRelationshipMessageInfo,		type RawLegacyUpdateRelationshipMessageInfo,
rawLegacyUpdateRelationshipMessageInfoValidator,		rawLegacyUpdateRelationshipMessageInfoValidator,
type LegacyUpdateRelationshipMessageData,		type LegacyUpdateRelationshipMessageData,
type LegacyUpdateRelationshipMessageInfo,		type LegacyUpdateRelationshipMessageInfo,
} from '../../types/messages/legacy-update-relationship.js';		} from '../../types/messages/legacy-update-relationship.js';
		import type {
		RawUpdateRelationshipMessageInfo,
		UpdateRelationshipMessageData,
		} from '../../types/messages/update-relationship.js';
import type { ThreadInfo } from '../../types/minimally-encoded-thread-permissions-types.js';		import type { ThreadInfo } from '../../types/minimally-encoded-thread-permissions-types.js';
import type { NotifTexts } from '../../types/notif-types.js';		import type { NotifTexts } from '../../types/notif-types.js';
import type { RelativeUserInfo } from '../../types/user-types.js';		import type { RelativeUserInfo } from '../../types/user-types.js';
import { type EntityText, ET } from '../../utils/entity-text.js';		import { type EntityText, ET } from '../../utils/entity-text.js';

type UpdateRelationshipMessageSpec = MessageSpec<		type UpdateRelationshipMessageSpec = MessageSpec<
LegacyUpdateRelationshipMessageData,		LegacyUpdateRelationshipMessageData,
RawLegacyUpdateRelationshipMessageInfo,		RawLegacyUpdateRelationshipMessageInfo,
LegacyUpdateRelationshipMessageInfo,		LegacyUpdateRelationshipMessageInfo,
> & {		> & {
// We need to explicitly type this as non-optional so that		// We need to explicitly type this as non-optional so that
// it can be referenced from messageContentForClientDB below		// it can be referenced from messageContentForClientDB below
+messageContentForServerDB: (		+messageContentForServerDB: (
data:		data:
\| LegacyUpdateRelationshipMessageData		\| LegacyUpdateRelationshipMessageData
\| RawLegacyUpdateRelationshipMessageInfo,		\| RawLegacyUpdateRelationshipMessageInfo
		\| UpdateRelationshipMessageData
		\| RawUpdateRelationshipMessageInfo,
) => string,		) => string,
...		...
};		};

export const updateRelationshipMessageSpec: UpdateRelationshipMessageSpec =		export const updateRelationshipMessageSpec: UpdateRelationshipMessageSpec =
Object.freeze({		Object.freeze({
messageContentForServerDB(		messageContentForServerDB(
data:		data:
\| LegacyUpdateRelationshipMessageData		\| LegacyUpdateRelationshipMessageData
\| RawLegacyUpdateRelationshipMessageInfo,		\| RawLegacyUpdateRelationshipMessageInfo
		\| UpdateRelationshipMessageData
		\| RawUpdateRelationshipMessageInfo,
): string {		): string {
return JSON.stringify({		return JSON.stringify({
operation: data.operation,		operation: data.operation,
targetID: data.targetID,		targetID: data.targetID,
});		});
},		},

messageContentForClientDB(		messageContentForClientDB(
▲ Show 20 Lines • Show All 128 Lines • Show Last 20 Lines

[lib] Update `messageContentFor[Client/Server]DB` to handle `UpdateRelationship`ClosedPublicActions