Paths

Table of Contentst

-
lib/shared/messages/
-
shared/
-
messages/
-
update-relationship-message-spec.js

[lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo`
ClosedPublic
Actions

Authored by atul on Mar 28 2024, 12:54 PM.

Details

Reviewers

ginsu
tomek
varun
will
ashoat

Commits

rCOMM88077c9da4b0: [lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo`

Summary

Shim UpdateRelationship messages with farcaster_mutual operation for now.

Based on the following from hackathon branch: https://github.com/CommE2E/comm/commit/6dcee7ca9c467951a11086fce416c85bb7f3d385

Depends on D11458

Test Plan

Unsupported robotext appears as expected:

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D11459 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 28 2024, 12:54 PM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 28 2024, 12:54 PM

Harbormaster completed remote builds in B27799: Diff 38494.Mar 28 2024, 1:10 PM

atul requested review of this revision.Mar 28 2024, 1:10 PM

I previously reviewed this code in person

lib/shared/messages/update-relationship-message-spec.js
241 ↗	(On Diff #38494)	Can we avoid copy-pasting this? Line 196 can be: ET`${string}`

This revision is now accepted and ready to land.Mar 28 2024, 7:09 PM

address feedback + land

Harbormaster completed remote builds in B28032: Diff 38878.Apr 5 2024, 6:01 PM

land

This revision was landed with ongoing or failed builds.Apr 8 2024, 6:17 AM

Closed by commit rCOMM88077c9da4b0: [lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM88077c9da4b0: [lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo`.

Harbormaster completed remote builds in B28045: Diff 38894.Apr 8 2024, 6:32 AM

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

update-relationship-message-spec.js

49 lines

Diff 38878

View Options

lib/shared/messages/update-relationship-message-spec.js

// @flow		// @flow

import * as React from 'react';		import * as React from 'react';
import { Text } from 'react-native';		import { Text } from 'react-native';

import { oldValidUsernameRegexString } from 'lib/shared/account-utils.js';		import { oldValidUsernameRegexString } from 'lib/shared/account-utils.js';
import {		import {
getNewTextAndSelection,		getNewTextAndSelection,
encodeChatMentionText,		encodeChatMentionText,
type Selection,		type Selection,
type TypeaheadTooltipActionItem,		type TypeaheadTooltipActionItem,
type MentionTypeaheadSuggestionItem,		type MentionTypeaheadSuggestionItem,
} from 'lib/shared/mention-utils.js';		} from 'lib/shared/mention-utils.js';
		import { validChatNameRegexString } from 'lib/shared/thread-utils.js';
import { stringForUserExplicit } from 'lib/shared/user-utils.js';		import { stringForUserExplicit } from 'lib/shared/user-utils.js';

		import ThreadAvatar from '../avatars/thread-avatar.react.js';
import UserAvatar from '../avatars/user-avatar.react.js';		import UserAvatar from '../avatars/user-avatar.react.js';
import type { TypeaheadTooltipStyles } from '../chat/typeahead-tooltip.react.js';		import type { TypeaheadTooltipStyles } from '../chat/typeahead-tooltip.react.js';

// Native regex is a little bit different than web one as		// Native regex is a little bit different than web one as
// there are no named capturing groups yet on native.		// there are no named capturing groups yet on native.
const nativeMentionTypeaheadRegex: RegExp = new RegExp(		const nativeMentionTypeaheadRegex: RegExp = new RegExp(
`((^(.\|\n)*\\s+)\|^)@(${oldValidUsernameRegexString})?$`,		`((^(.\|\n)*\\s+)\|^)@(${oldValidUsernameRegexString}\|${validChatNameRegexString})?$`,
);		);

export type TypeaheadTooltipActionsParams<SuggestionType> = {		export type TypeaheadTooltipActionsParams<SuggestionType> = {
+suggestions: $ReadOnlyArray<SuggestionType>,		+suggestions: $ReadOnlyArray<SuggestionType>,
+textBeforeAtSymbol: string,		+textBeforeAtSymbol: string,
+text: string,		+text: string,
+textPrefix: string,		+textPrefix: string,
+focusAndUpdateTextAndSelection: (text: string, selection: Selection) => void,		+focusAndUpdateTextAndSelection: (text: string, selection: Selection) => void,
Show All 31 Lines	if (suggestion.type === 'user') {
});		});
},		},
actionButtonContent: {		actionButtonContent: {
type: 'user',		type: 'user',
userInfo,		userInfo,
},		},
});		});
} else if (suggestion.type === 'chat') {		} else if (suggestion.type === 'chat') {
const { chat } = suggestion;		const { threadInfo } = suggestion;
const mentionText = `@[[${chat.id}:${encodeChatMentionText(		const mentionText = `@[[${threadInfo.id}:${encodeChatMentionText(
chat.uiName,		threadInfo.uiName,
)}]]`;		)}]]`;
actions.push({		actions.push({
key: chat.id,		key: threadInfo.id,
execute: () => {		execute: () => {
const { newText, newSelectionStart } = getNewTextAndSelection(		const { newText, newSelectionStart } = getNewTextAndSelection(
textBeforeAtSymbol,		textBeforeAtSymbol,
text,		text,
textPrefix,		textPrefix,
mentionText,		mentionText,
);		);
focusAndUpdateTextAndSelection(newText, {		focusAndUpdateTextAndSelection(newText, {
start: newSelectionStart,		start: newSelectionStart,
end: newSelectionStart,		end: newSelectionStart,
});		});
},		},
actionButtonContent: {		actionButtonContent: {
type: 'chat',		type: 'chat',
chat,		threadInfo,
},		},
});		});
}		}
}		}
return actions;		return actions;
}		}

export type TypeaheadTooltipButtonRendererParams<SuggestionItemType> = {		export type TypeaheadTooltipButtonRendererParams<SuggestionItemType> = {
+item: TypeaheadTooltipActionItem<SuggestionItemType>,		+item: TypeaheadTooltipActionItem<SuggestionItemType>,
+styles: TypeaheadTooltipStyles,		+styles: TypeaheadTooltipStyles,
};		};
function mentionTypeaheadTooltipButtonRenderer({		function mentionTypeaheadTooltipButtonRenderer({
item,		item,
styles,		styles,
}: TypeaheadTooltipButtonRendererParams<MentionTypeaheadSuggestionItem>): React.Node {		}: TypeaheadTooltipButtonRendererParams<MentionTypeaheadSuggestionItem>): React.Node {
let avatarComponent = null;		let avatarComponent = null;
let typeaheadTooltipButtonText = null;		let typeaheadTooltipButtonText = null;
if (item.actionButtonContent.type === 'user') {		if (item.actionButtonContent.type === 'user') {
avatarComponent = (		avatarComponent = (
<UserAvatar size="small" userID={item.actionButtonContent.userInfo.id} />		<UserAvatar size="small" userID={item.actionButtonContent.userInfo.id} />
);		);
typeaheadTooltipButtonText = item.actionButtonContent.userInfo.username;		typeaheadTooltipButtonText = item.actionButtonContent.userInfo.username;
		} else if (item.actionButtonContent.type === 'chat') {
		typeaheadTooltipButtonText = item.actionButtonContent.threadInfo.uiName;
		avatarComponent = (
		<ThreadAvatar
		size="small"
		threadInfo={item.actionButtonContent.threadInfo}
		/>
		);
}		}
return (		return (
<>		<>
{avatarComponent}		{avatarComponent}
<Text style={styles.buttonLabel} numberOfLines={1}>		<Text style={styles.buttonLabel} numberOfLines={1}>
{typeaheadTooltipButtonText}		{typeaheadTooltipButtonText}
</Text>		</Text>
</>		</>
);		);
}		}

export {		export {
nativeMentionTypeaheadRegex,		nativeMentionTypeaheadRegex,
mentionTypeaheadTooltipActions,		mentionTypeaheadTooltipActions,
mentionTypeaheadTooltipButtonRenderer,		mentionTypeaheadTooltipButtonRenderer,
};		};

[lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo`ClosedPublicActions