Page MenuHomePhabricator
Differential D11459

[lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo`
ClosedPublic
Actions

Authored by atul on Mar 28 2024, 12:54 PM.
Tags
None
Referenced Files
F6414000: D11459.diff
Mon, Apr 28, 2:38 PM
Unknown Object (File)
Fri, Apr 25, 12:36 AM
Unknown Object (File)
Sun, Apr 20, 6:30 PM
Unknown Object (File)
Mon, Apr 14, 12:19 PM
Unknown Object (File)
Fri, Apr 11, 11:14 AM
Unknown Object (File)
Thu, Apr 10, 10:56 PM
Unknown Object (File)
Wed, Apr 9, 12:36 AM
Unknown Object (File)
Tue, Apr 8, 9:08 PM
View All 96 Files
Subscribers
ashoat

Details

Reviewers
ginsu
tomek
varun
will
ashoat
Commits
rCOMM88077c9da4b0: [lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo`
Summary

Shim UpdateRelationship messages with farcaster_mutual operation for now.

Based on the following from hackathon branch: https://github.com/CommE2E/comm/commit/6dcee7ca9c467951a11086fce416c85bb7f3d385

Depends on D11458

Test Plan

Unsupported robotext appears as expected:

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D11459 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Mar 28 2024, 12:54 PM
Herald added a subscriber: ashoat. · View Herald TranscriptMar 28 2024, 12:54 PM
Harbormaster completed remote builds in B27799: Diff 38494.Mar 28 2024, 1:10 PM
atul requested review of this revision.Mar 28 2024, 1:10 PM
ashoat accepted this revision.Mar 28 2024, 7:09 PM

I previously reviewed this code in person

lib/shared/messages/update-relationship-message-spec.js
241 ↗(On Diff #38494)

Can we avoid copy-pasting this?

Line 196 can be:

ET`${string}`
This revision is now accepted and ready to land.Mar 28 2024, 7:09 PM
atul updated this revision to Diff 38878.Apr 5 2024, 5:45 PM

address feedback + land

Harbormaster completed remote builds in B28032: Diff 38878.Apr 5 2024, 6:01 PM
atul updated this revision to Diff 38894.Apr 8 2024, 6:16 AM

land

This revision was landed with ongoing or failed builds.Apr 8 2024, 6:17 AM
Closed by commit rCOMM88077c9da4b0: [lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM88077c9da4b0: [lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo`.
Harbormaster completed remote builds in B28045: Diff 38894.Apr 8 2024, 6:32 AM

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
49 lines

Diff 38878

View Options

lib/shared/messages/update-relationship-message-spec.js

Loading...