Page MenuHomePhabricator
Differential D11567

[lib/native/web] introduce alert types
ClosedPublic
Actions

Authored by ginsu on Apr 7 2024, 8:21 PM.
Tags
None
Referenced Files
F3391263: D11567.diff
Sat, Nov 30, 3:01 AM
Unknown Object (File)
Wed, Nov 27, 1:57 AM
Unknown Object (File)
Wed, Nov 27, 1:49 AM
Unknown Object (File)
Sun, Nov 3, 8:22 AM
Unknown Object (File)
Oct 12 2024, 8:50 PM
Unknown Object (File)
Oct 12 2024, 8:50 PM
Unknown Object (File)
Oct 12 2024, 8:50 PM
Unknown Object (File)
Oct 12 2024, 8:50 PM
View All 57 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM9e6a658b2b6c: [lib/native/web] introduce alert types
Summary

This diff introduces the alert info + alert store types and starts to refactor + rename notifPermissionAlertInfo => alertInfo.

Please note that some of the renaming is not done yet. This is because we also need to do some refactoring to turn the notif permission alert info reducer to be the alert info reducer before we can change the variable names in some instances.

Linear task: https://linear.app/comm/issue/ENG-7620/introduce-alertinfos-alertinfostore-type

Depends on D11598

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Apr 7 2024, 8:21 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 7 2024, 8:21 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 7 2024, 8:23 PM
Harbormaster failed remote builds in B28033: Diff 38879!
ginsu requested review of this revision.Apr 7 2024, 8:24 PM
ginsu edited the summary of this revision. (Show Details)
ginsu added reviewers: atul, inka.

will make sure ci passes before landing

ginsu added a child revision: D11568: [lib/native/web] refactor notif permission alert info reducer.Apr 7 2024, 8:40 PM
atul accepted this revision.Apr 8 2024, 6:18 AM
atul added inline comments.
lib/reducers/notif-permission-alert-info-reducer.js
7

Should we also change name of reduce* function? What about the filename?

This revision is now accepted and ready to land.Apr 8 2024, 6:18 AM
atul added inline comments.Apr 8 2024, 6:25 AM
lib/reducers/notif-permission-alert-info-reducer.js
7

Actually makes sense that you're just handling types in this diff.

ginsu edited the summary of this revision. (Show Details)Apr 9 2024, 10:16 AM
ginsu added a parent revision: D11598: [native] handle successful connection from connect farcaster bottom sheet.
ginsu updated this revision to Diff 38990.Apr 10 2024, 10:54 AM

rebase before landing + make sure ci passes

Harbormaster completed remote builds in B28130: Diff 38990.Apr 10 2024, 11:09 AM
Closed by commit rCOMM9e6a658b2b6c: [lib/native/web] introduce alert types (authored by ginsu). · Explain WhyApr 10 2024, 11:16 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM9e6a658b2b6c: [lib/native/web] introduce alert types.

Revision Contents
Changeset List

PathSize
lib/
reducers/
10 lines
types/
27 lines
4 lines
utils/
20 lines
4 lines
native/
push/
4 lines
redux/
4 lines
4 lines
4 lines
web/
redux/
4 lines
4 lines

Diff 38879

View Options

lib/reducers/notif-permission-alert-info-reducer.js

Loading...
View Options

lib/types/alert-types.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

lib/utils/push-alerts.js

Loading...
View Options

lib/utils/reducers-utils.test.js

Loading...
View Options

native/push/push-handler.react.js

Loading...
View Options

native/redux/default-state.js

Loading...
View Options

native/redux/persist.js

Loading...
View Options

native/redux/state-types.js

Loading...
View Options

web/redux/default-state.js

Loading...
View Options

web/redux/redux-setup.js

Loading...