Page MenuHomePhabricator
Differential D11616

[native] migrate threadActivityStore to SQLite
ClosedPublic
Actions

Authored by will on Apr 9 2024, 11:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 31, 5:32 PM
Unknown Object (File)
Fri, Mar 28, 8:23 PM
Unknown Object (File)
Sun, Mar 16, 2:13 AM
Unknown Object (File)
Sat, Mar 15, 5:34 AM
Unknown Object (File)
Sat, Mar 15, 5:34 AM
Unknown Object (File)
Sat, Mar 15, 5:34 AM
Unknown Object (File)
Sat, Mar 15, 5:34 AM
Unknown Object (File)
Sat, Mar 15, 5:34 AM
View All 86 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM408f153e9e31: [native] migrate threadActivityStore to SQLite
Summary

This migrates threadActivityStore to SQLite

Depends on D11615

Test Plan

Rebased to prior commit without threadActivity sqlite changes. Populated redux persist with thread activity entries via dispatch actions. Rebased back to current commits without migration. Encountered state difference due to missing migration. Ran the migration and previous entries are included in the sqlite database

Screenshot 2024-04-15 at 10.09.45 AM.png (1×1 px, 359 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Apr 9 2024, 11:03 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 9 2024, 11:03 PM
will edited the summary of this revision. (Show Details)Apr 9 2024, 11:05 PM
will added a parent revision: D11615: [sqlite] Implement processing thread activity on web worker.
will added a child revision: D11617: [native][web] Start processing thread activity store with sqlite operations.Apr 9 2024, 11:08 PM
will mentioned this in D11618: [native][web] Read thread activity entries from SQLite on app start.Apr 9 2024, 11:13 PM
Harbormaster completed remote builds in B28119: Diff 38975.Apr 9 2024, 11:18 PM
will requested review of this revision.Apr 9 2024, 11:18 PM
atul accepted this revision.Apr 11 2024, 6:16 PM
This revision is now accepted and ready to land.Apr 11 2024, 6:16 PM
will edited the test plan for this revision. (Show Details)Apr 15 2024, 7:09 AM
will updated this revision to Diff 39168.Apr 16 2024, 9:04 PM

rebase

Harbormaster completed remote builds in B28257: Diff 39168.Apr 16 2024, 9:21 PM
will updated this revision to Diff 39305.Apr 19 2024, 11:42 AM

rebase before landing

Harbormaster failed remote builds in B28339: Diff 39305!Apr 19 2024, 11:52 AM
Harbormaster completed remote builds in B28339: Diff 39305.Apr 19 2024, 12:18 PM
Closed by commit rCOMM408f153e9e31: [native] migrate threadActivityStore to SQLite (authored by will). · Explain WhyApr 19 2024, 1:08 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM408f153e9e31: [native] migrate threadActivityStore to SQLite.

Revision Contents
Changeset List

PathSize
native/
redux/
33 lines

Diff 39168

View Options

native/redux/persist.js

mod proto { mod proto {
tonic::include_proto!("blob"); tonic::include_proto!("blob");
} }
use proto::blob_service_client::BlobServiceClient; use proto::blob_service_client::BlobServiceClient;
use proto::put_request; use proto::put_request;
use proto::put_request::Data::*; use proto::put_request::Data::*;
use proto::PutRequest; use proto::PutRequest;
use crate::constants::{BLOB_ADDRESS, MPSC_CHANNEL_BUFFER_CAPACITY}; use crate::constants::{BLOB_ADDRESS, MPSC_CHANNEL_BUFFER_CAPACITY};
use crate::tools::{ use crate::tools::{
c_char_pointer_to_string, c_char_pointer_to_string_new, check_error, c_char_pointer_to_string, c_char_pointer_to_string_new, report_error, string_to_c_char_pointer_new,
report_error, string_to_c_char_pointer, string_to_c_char_pointer_new,
}; };
use anyhow::bail; use anyhow::bail;
use lazy_static::lazy_static; use lazy_static::lazy_static;
use libc; use libc;
use libc::c_char; use libc::c_char;
use std::collections::HashMap; use std::collections::HashMap;
use std::ffi::CStr; use std::ffi::CStr;
use std::sync::Mutex; use std::sync::Mutex;
▲ Show 20 Lines • Show All 172 Lines • ▼ Show 20 Lines if let Ok(mut grpc_client) =
} }
return Err(format!("could not access client for holder {}", holder)); return Err(format!("could not access client for holder {}", holder));
} }
Err("could not successfully connect to the blob server".to_string()) Err("could not successfully connect to the blob server".to_string())
} }
pub fn put_client_blocking_read_cxx( pub fn put_client_blocking_read_cxx(
holder_char: *const c_char, holder_char: *const c_char,
) -> Result<String, String> { ) -> anyhow::Result<String, anyhow::Error> {
tomekUnsubmitted
Not Done
Inline Actions
holder_char: *const c_char,
- ) -> anyhow::Result<String, anyhow::Error> {
+ ) -> anyhow::Result<String> {
let holder = c_char_pointer_to_string_new(holder_char)?;
tomek:
let holder = c_char_pointer_to_string(holder_char)?; let holder = c_char_pointer_to_string_new(holder_char)?;
check_error(&ERROR_MESSAGES)?; Ok(RUNTIME.block_on(async {
let response: Option<String> = RUNTIME.block_on(async {
if let Ok(mut clients) = CLIENTS.lock() { if let Ok(mut clients) = CLIENTS.lock() {
let maybe_client = clients.get_mut(&holder); let maybe_client = clients.get_mut(&holder);
if let Some(client) = maybe_client { if let Some(client) = maybe_client {
if let Some(data) = client.rx.recv().await { if let Some(data) = client.rx.recv().await {
return Some(data); return Ok(data);
} else { } else {
report_error( bail!("couldn't receive data via client's receiver");
&ERROR_MESSAGES,
"couldn't receive data via client's receiver",
Some("put"),
);
} }
} else { } else {
report_error( bail!(format!("no client detected for {} in blocking read", holder));
&ERROR_MESSAGES,
"no client detected in blocking read",
Some("put"),
);
} }
} else { } else {
report_error(&ERROR_MESSAGES, "couldn't access client", Some("put")); bail!("couldn't access clients");
} }
None })?)
});
check_error(&ERROR_MESSAGES)?;
response.ok_or("response not received properly".to_string())
} }
/** /**
* field index: * field index:
* 1 - holder (utf8 string) * 1 - holder (utf8 string)
* 2 - blob hash (utf8 string) * 2 - blob hash (utf8 string)
* 3 - data chunk (bytes) * 3 - data chunk (bytes)
*/ */
▲ Show 20 Lines • Show All 60 Lines • Show Last 20 Lines